From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Add Baytrail PSR Support. Date: Wed, 29 Jan 2014 20:20:08 +0100 Message-ID: <20140129192008.GJ7444@phenom.ffwll.local> References: <1390938445-4666-1-git-send-email-rodrigo.vivi@gmail.com> <1390999674-7982-1-git-send-email-rodrigo.vivi@gmail.com> <20140129131251.GA28110@nuc-i3427.alporthouse.com> <20140129132755.GD28110@nuc-i3427.alporthouse.com> <20140129140227.GE28110@nuc-i3427.alporthouse.com> <20140129142603.GF28110@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C2C2FCB57 for ; Wed, 29 Jan 2014 11:20:13 -0800 (PST) Received: by mail-ee0-f41.google.com with SMTP id e49so1142024eek.28 for ; Wed, 29 Jan 2014 11:20:12 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140129142603.GF28110@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Rodrigo Vivi , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 29, 2014 at 02:26:03PM +0000, Chris Wilson wrote: > On Wed, Jan 29, 2014 at 12:23:15PM -0200, Rodrigo Vivi wrote: > > ok, got it. > > > > So, the correct here is to remove inactivate from set_domain and add > > gem_bo_busy call on MMAP_GTT testcase? > > That would match what we should do today. It's just whether we take the > opportunity to define a consistent behaviour... Afaik we don't do a gem_bo_busy after gtt access, at least no everwhere. Which sucks, but meh. At least I've thought that the busy is just after gpu rendering. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch