From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: enable HiZ Raw Stall Optimization on HSW Date: Thu, 30 Jan 2014 14:40:10 +0200 Message-ID: <20140130124010.GK9454@intel.com> References: <1390810716-13510-1-git-send-email-olvaffe@gmail.com> <1390886974-2530-1-git-send-email-olvaffe@gmail.com> <20140130121007.GR17001@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id EE07E1005B3 for ; Thu, 30 Jan 2014 04:40:36 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140130121007.GR17001@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 30, 2014 at 01:10:07PM +0100, Daniel Vetter wrote: > On Wed, Jan 29, 2014 at 06:23:40PM -0800, Matt Turner wrote: > > On Wed, Jan 29, 2014 at 9:56 AM, Daniel Vetter wrote: > > > On Tue, Jan 28, 2014 at 6:29 AM, Chia-I Wu wrote: > > >> From: Chia-I Wu > > >> > > >> The optimization is available on Ivy Bridge and later, and is disabl= ed by > > >> default. Enabling it helps certain workloads such as GLBenchmark TR= ex test. > > >> > > >> No piglit regression. > > >> > > >> v2 > > >> - no need to save the register before suspend as init_clock_gating = can > > >> correctly program it after resume > > >> - split IVB change to another commit > > >> > > >> Signed-off-by: Chia-I Wu > > > > > > What about byt? > > > -Daniel > > = > > In the previous thread, Ville pointed out that the documentation > > doesn't say anything about BYT for this bit, so it's unknown whether > > it's supported, and Chia-I said > > = > > > Though I will leave BDW/VLV out as I do not have the hardware. > > = > > I do have BYT, so I'll check it out, but this patch can go in without > > it that information, since Chia-I took Ville's advice and split the > > patches into per-generation hunks. > = > Make sense. Patches merged and I'll happily pull in the byt update if that > one checks out ok. and bdw also needs this (bspec says hsw+) -- = Ville Syrj=E4l=E4 Intel OTC