From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 09/13] drm/i915/bdw: poll semaphores Date: Thu, 30 Jan 2014 15:26:11 +0200 Message-ID: <20140130132611.GN9454@intel.com> References: <1391025333-31587-1-git-send-email-benjamin.widawsky@intel.com> <1391025333-31587-10-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 24C75FFD02 for ; Thu, 30 Jan 2014 05:26:21 -0800 (PST) Content-Disposition: inline In-Reply-To: <1391025333-31587-10-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 29, 2014 at 11:55:29AM -0800, Ben Widawsky wrote: > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 1 + > 1 file changed, 1 insertion(+) > = > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i9= 15/intel_ringbuffer.c > index 3cfcc78..3a3ba81 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -812,6 +812,7 @@ gen8_ring_sync(struct intel_ring_buffer *waiter, > = > intel_ring_emit(waiter, MI_SEMAPHORE_WAIT | > MI_SEMAPHORE_GLOBAL_GTT | > + MI_SEMAPHORE_POLL | > MI_SEMAPHORE_SAD_GTE_SDD); I was thinking that we shouldn't need this. However the docs suck a bit and they don't actually specify whether the hardware will wait for the signal before even checking the semaphore once. But that sounds so wrong that it can't possibly be true. > intel_ring_emit(waiter, seqno); > intel_ring_emit(waiter, > -- = > 1.8.5.3 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC