From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/5] drm/i915: Adding VBT fields to support eDP DRRS feature Date: Tue, 4 Feb 2014 11:34:35 +0100 Message-ID: <20140204103435.GC17001@phenom.ffwll.local> References: <1387785153-5329-1-git-send-email-vandana.kannan@intel.com> <1387785153-5329-2-git-send-email-vandana.kannan@intel.com> <87ppnk5fk5.fsf@intel.com> <52E9C734.4040107@intel.com> <87a9ee2dpn.fsf@intel.com> <52EF1055.1090706@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B070FC04C for ; Tue, 4 Feb 2014 02:34:44 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id d17so4174910eek.8 for ; Tue, 04 Feb 2014 02:34:43 -0800 (PST) Content-Disposition: inline In-Reply-To: <52EF1055.1090706@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Vandana Kannan Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Mon, Feb 03, 2014 at 09:13:17AM +0530, Vandana Kannan wrote: > > Again, everywhere else in intel_bios.c we use panel_type, directly as it > > is in VBT, 0-based. Are you saying it's all wrong? panel_type can't be > > 1-based in this one instance, and 0-based in all other instances, right? > > > > This is actually the first priority to check. > > > I have discussed with the author of the patch and i will modify this to > make panel_type 0-based. Can we drag the author of the patch itself into this discussion, here on intel-gfx? Generally round-trip is much faster if we cut out as many middlemen as possible ... This is just a general upstreaming bkm. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch