From: Daniel Vetter <daniel@ffwll.ch>
To: "S, Deepak" <deepak.s@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v6] drm/i915/vlv: WA to fix Voltage not getting dropped to Vmin when Gfx is power gated.
Date: Tue, 4 Feb 2014 11:59:49 +0100 [thread overview]
Message-ID: <20140204105949.GI17001@phenom.ffwll.local> (raw)
In-Reply-To: <52EBDFE3.6070707@intel.com>
On Fri, Jan 31, 2014 at 11:09:47PM +0530, S, Deepak wrote:
> On 1/31/2014 10:40 PM, Ville Syrjälä wrote:
> >On Thu, Jan 30, 2014 at 11:08:16PM +0530, deepak.s@intel.com wrote:
> >>From: Deepak S <deepak.s@intel.com>
> >>
> >>When we enter RC6 and GFX Clocks are off, the voltage remains higher
> >>than Vmin. When we try to set the freq to RPn, it might fail since the
> >>Gfx clocks are down. So to fix this in Gfx idle, Bring the GFX clock up
> >>and set the freq to RPn then move GFx down.
> >>
> >>v2: remove vlv_update_rps_cur_delay function. Update commit message (Daniel)
> >>
> >>v3: Fix the timeout during wait for gfx clock (Jesse)
> >>
> >>v4: addressed comments on set freq and punit wait (Ville)
> >>
> >>v5: use wait_for while waiting for GFX clk to be up. (Daniel)
> >> update cur_delay before requesting min_delay. (Ville)
> >>
> >>v6: use wait_for while waiting for punit. (Ville)
> >>
> >>Signed-off-by: Deepak S <deepak.s@intel.com>
> >>Reviewed-by: Ville Syrjä <ville.syrjala@linux.intel.com>
> > ^^
> >
> >Stuff missing from my name.
> Sorry Something got missed while uploading the patch :(
Fixed and patche merged, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-02-04 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 17:38 [PATCH v6] drm/i915/vlv: WA to fix Voltage not getting dropped to Vmin when Gfx is power gated deepak.s
2014-01-31 17:10 ` Ville Syrjälä
2014-01-31 17:39 ` S, Deepak
2014-02-04 10:59 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204105949.GI17001@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox