From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Treat using a purged buffer as a source of EFAULT Date: Tue, 4 Feb 2014 12:05:13 +0100 Message-ID: <20140204110513.GJ17001@phenom.ffwll.local> References: <1391168098-23161-1-git-send-email-chris@chris-wilson.co.uk> <1391168098-23161-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com [209.85.215.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E950FC6E5 for ; Tue, 4 Feb 2014 03:05:18 -0800 (PST) Received: by mail-ea0-f181.google.com with SMTP id m10so4328740eaj.12 for ; Tue, 04 Feb 2014 03:05:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <1391168098-23161-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jan 31, 2014 at 11:34:58AM +0000, Chris Wilson wrote: > Since a purged buffer is one without any associated pages, attempting to > use it should generate EFAULT rather than EINVAL, as it is not strictly > an invalid parameter. > > Signed-off-by: Chris Wilson Care to drop a quick testcase into i-g-t to encode this return value change? Also, any plans to use this with userspace somehow, or what's the motivation for this? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch