From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/7] drm/i915: factor out valleyview_pipestat_irq_handler Date: Wed, 5 Feb 2014 17:05:16 +0100 Message-ID: <20140205160516.GH17001@phenom.ffwll.local> References: <1391542551-20239-1-git-send-email-imre.deak@intel.com> <1391542551-20239-3-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D5344198 for ; Wed, 5 Feb 2014 08:05:20 -0800 (PST) Received: by mail-ee0-f42.google.com with SMTP id b15so326330eek.15 for ; Wed, 05 Feb 2014 08:05:20 -0800 (PST) Content-Disposition: inline In-Reply-To: <1391542551-20239-3-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Feb 04, 2014 at 09:35:46PM +0200, Imre Deak wrote: > This will be used by other platforms too, so factor it out. > > The only functional change is the reordeing of gmbus_irq_handler() wrt. > the hotplug handling, but since it only schedules a work, it isn't an > issue. > > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_irq.c | 76 +++++++++++++++++++++++------------------ > 1 file changed, 42 insertions(+), 34 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 137ac65..b5524ea 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1477,15 +1477,53 @@ static void gen6_rps_irq_handler(struct drm_i915_private *dev_priv, u32 pm_iir) > } > } > > +static void valleyview_pipestat_irq_handler(struct drm_device *dev, u32 iir) > +{ > + drm_i915_private_t *dev_priv = dev->dev_private; typedefs for structs are frowned upon. I've fixed this while applying. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch