From: Daniel Vetter <daniel@ffwll.ch>
To: sagar.a.kamble@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 01/12] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h
Date: Thu, 6 Feb 2014 17:51:53 +0100 [thread overview]
Message-ID: <20140206165153.GP17001@phenom.ffwll.local> (raw)
In-Reply-To: <1391699093-12625-2-git-send-email-sagar.a.kamble@intel.com>
On Thu, Feb 06, 2014 at 08:34:42PM +0530, sagar.a.kamble@intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> The rotation property stuff should be standardized among all drivers.
> Move the bits to drm_crtc.h from omap_drv.h.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Tested-by: Sagar Kamble <sagar.a.kamble@intel.com>
Patches which touch code outside of i915 must be submitted to the
dri-devel mailing list. Also, since you're touching a driver please also
cc the driver maintainers/authors (Tomi/Rob in this case) so that they'll
notice the patch.
scripts/get_maintainers.pl can help you with adding a reasonable Cc: list
to the sob section of your patches.
-Daniel
> ---
> drivers/gpu/drm/omapdrm/omap_drv.h | 7 -------
> include/drm/drm_crtc.h | 8 ++++++++
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h
> index 428b2981..aac8e10 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.h
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.h
> @@ -119,13 +119,6 @@ struct omap_drm_private {
> struct omap_drm_irq error_handler;
> };
>
> -/* this should probably be in drm-core to standardize amongst drivers */
> -#define DRM_ROTATE_0 0
> -#define DRM_ROTATE_90 1
> -#define DRM_ROTATE_180 2
> -#define DRM_ROTATE_270 3
> -#define DRM_REFLECT_X 4
> -#define DRM_REFLECT_Y 5
>
> #ifdef CONFIG_DEBUG_FS
> int omap_debugfs_init(struct drm_minor *minor);
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 71727b6..d5c46c1 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -65,6 +65,14 @@ struct drm_object_properties {
> uint64_t values[DRM_OBJECT_MAX_PROPERTY];
> };
>
> +/* rotation property bits */
> +#define DRM_ROTATE_0 0
> +#define DRM_ROTATE_90 1
> +#define DRM_ROTATE_180 2
> +#define DRM_ROTATE_270 3
> +#define DRM_REFLECT_X 4
> +#define DRM_REFLECT_Y 5
> +
> /*
> * Note on terminology: here, for brevity and convenience, we refer to connector
> * control chips as 'CRTCs'. They can control any type of connector, VGA, LVDS,
> --
> 1.8.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-02-06 16:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 15:04 [PATCH v3 00/12] Enabling 180 degree rotation for sprite and crtc planes sagar.a.kamble
2014-02-06 15:04 ` [PATCH v3 01/12] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h sagar.a.kamble
2014-02-06 16:51 ` Daniel Vetter [this message]
2014-02-06 15:04 ` [PATCH v3 02/12] drm: Add support_bits parameter to drm_property_create_bitmask() sagar.a.kamble
2014-02-06 15:04 ` [PATCH v3 03/12] drm: Add drm_mode_create_rotation_property() sagar.a.kamble
2014-02-06 15:04 ` [PATCH v3 04/12] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property() sagar.a.kamble
2014-02-06 15:04 ` [PATCH v3 05/12] drm: Add drm_rect rotation functions sagar.a.kamble
2014-02-06 15:04 ` [PATCH v3 06/12] drm: Add drm_rotation_simplify() sagar.a.kamble
2014-02-06 15:04 ` [PATCH v3 07/12] drm/i915: Add 180 degree sprite rotation support sagar.a.kamble
2014-02-06 15:04 ` [PATCH v3 08/12] drm/i915: Make intel_plane_restore() return an error sagar.a.kamble
2014-02-06 15:04 ` [PATCH v3 09/12] drm/i915: Add rotation property for sprites sagar.a.kamble
2014-02-06 15:04 ` [PATCH v3 10/12] drm/i915: Add 180 degree primary plane rotation support sagar.a.kamble
2014-02-06 15:56 ` Ville Syrjälä
2014-02-06 15:04 ` [PATCH v3 11/12] drm: Set property to return invalid for unsupported arguments for bitmask property sagar.a.kamble
2014-02-06 16:21 ` Ville Syrjälä
2014-02-06 15:04 ` [PATCH v3 12/12] drm/i915: Removing rotate and inverse rotate calls from update_plane sagar.a.kamble
2014-02-06 15:55 ` Ville Syrjälä
2014-02-06 16:29 ` [PATCH v3 00/12] Enabling 180 degree rotation for sprite and crtc planes Ville Syrjälä
2014-02-06 17:13 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140206165153.GP17001@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sagar.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox