From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH i-g-t] lib: fix signed/unsigned comparison
 issues
Date: Thu, 6 Feb 2014 18:33:33 +0100
Message-ID: <20140206173333.GS17001@phenom.ffwll.local>
References: <1391704314-26068-1-git-send-email-thomas.wood@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com
	[209.85.215.170])
	by gabe.freedesktop.org (Postfix) with ESMTP id 4299CFB5DC
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  6 Feb 2014 09:33:40 -0800 (PST)
Received: by mail-ea0-f170.google.com with SMTP id k10so1070812eaj.1
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 06 Feb 2014 09:33:37 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1391704314-26068-1-git-send-email-thomas.wood@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Thomas Wood <thomas.wood@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Feb 06, 2014 at 04:31:54PM +0000, Thomas Wood wrote:
> Store the result of set_vt_mode as a signed value so that errors can be
> caught correctly.
> 
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>

Both merged, thanks.
-Daniel

> ---
>  lib/igt_kms.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 3960d24..5f341ff 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -620,15 +620,16 @@ static void restore_vt_mode_at_exit(int sig)
>  
>  void igt_set_vt_graphics_mode(void)
>  {
> +	long ret;
> +
>  	igt_install_exit_handler(restore_vt_mode_at_exit);
>  
>  	igt_disable_exit_handler();
> -	orig_vt_mode = set_vt_mode(KD_GRAPHICS);
> -	if (orig_vt_mode < 0)
> -		orig_vt_mode = -1UL;
> +	ret = set_vt_mode(KD_GRAPHICS);
>  	igt_enable_exit_handler();
>  
> -	igt_assert(orig_vt_mode >= 0);
> +	igt_assert(ret >= 0);
> +	orig_vt_mode = ret;
>  }
>  
>  int kmstest_get_connector_default_mode(int drm_fd, drmModeConnector *connector,
> -- 
> 1.8.5.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch