From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 3/3] drm/i915: Make infoframe trnsmission more reliable on g4x Date: Mon, 10 Feb 2014 12:16:14 +0000 Message-ID: <20140210121614.GC9282@strange.amr.corp.intel.com> References: <1390511735-13677-1-git-send-email-ville.syrjala@linux.intel.com> <1390511735-13677-4-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 22377F9E36 for ; Mon, 10 Feb 2014 04:16:20 -0800 (PST) Content-Disposition: inline In-Reply-To: <1390511735-13677-4-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 23, 2014 at 11:15:35PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > On g4x there's just one video DIP, but there can be two HDMI/DVI > ports. Currently even a DVI monitor on another port can clobber > the infoframes meant for a real HDMI monitor on the other port. > = > Make sure we only ever send DIPs to one port. The first port with a > HDMI sink to get there gets to own the DIP until such time that the > port is completely turned off (ie. not just DPMS off). If there are > two HDMI sinks attached, the one to arrive second doesn't get any > infoframes. And if there's a DVI sink on the other port, it will > no longer disable DIP transmission for the other port. > = > Signed-off-by: Ville Syrj=E4l=E4 Reviewed-by: Damien Lespiau I guess follow-up patches could turn off Video DIPs on other platforms, if I read the code correctly we're always leaving Video DIPs on when disabling the pipe. -- = Damien