From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 2/8] drm/i915: Make the intel_device_info structure kept in dev_priv writable Date: Mon, 10 Feb 2014 14:06:16 +0000 Message-ID: <20140210140616.GD9282@strange.amr.corp.intel.com> References: <1391800374-24904-1-git-send-email-damien.lespiau@intel.com> <1391800374-24904-3-git-send-email-damien.lespiau@intel.com> <20140210090911.GL17001@phenom.ffwll.local> <20140210125329.GH3891@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AF32FA77A for ; Mon, 10 Feb 2014 06:06:39 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140210125329.GH3891@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Feb 10, 2014 at 02:53:29PM +0200, Ville Syrj=E4l=E4 wrote: > > Since every access should now go through the macro I think it'd be good= to > > give this a __ prefix to make it clear that users better think twice > > before using it. Maybe as a patch on top of all this? > = > No. Everyone having to use the macro was a requirement of the v2 patch. > With v3 that requirement was lifted since the const is right there on > the struct itself. I think that was the whole point of v3. The "everyone should now go through the macro" is not for the const. There's a new idea floating around to replace the macros by hardcoded values to be able to compile the driver for a specific platform and use the compiler dead code elimiation pass(es) to reduce the text size. There may be more cunning ways to reduce the driver size, haven't thought much about it. -- = Damien