From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 6/3] drm/i915: remove "dsi" argument form intel_enable_pipe Date: Mon, 10 Feb 2014 18:19:29 +0100 Message-ID: <20140210171929.GY17001@phenom.ffwll.local> References: <1389973873-2005-1-git-send-email-przanoni@gmail.com> <1389973873-2005-3-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com [209.85.215.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 6EEE0FA7EC for ; Mon, 10 Feb 2014 09:19:37 -0800 (PST) Received: by mail-ea0-f170.google.com with SMTP id g15so1368197eak.1 for ; Mon, 10 Feb 2014 09:19:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <1389973873-2005-3-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Paulo Zanoni , Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Fri, Jan 17, 2014 at 01:51:11PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > Now that we pass struct intel_crtc as an argument, we can check for > DSI inside the function, removing one more of those confusing boolean > arguments. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_display.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 1e5ad04..b110da8 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -1745,14 +1745,12 @@ static void lpt_disable_pch_transcoder(struct drm_i915_private *dev_priv) > /** > * intel_enable_pipe - enable a pipe, asserting requirements > * @crtc: crtc responsible for the pipe > - * @dsi: output type is DSI > * @wait_for_vblank: whether we should for a vblank or not after enabling it > * > * Enable @crtc's pipe, making sure that various hardware specific requirements > * are met, if applicable, e.g. PLL enabled, LVDS pairs enabled, etc. > */ > -static void intel_enable_pipe(struct intel_crtc *crtc, > - bool dsi, bool wait_for_vblank) > +static void intel_enable_pipe(struct intel_crtc *crtc, bool wait_for_vblank) > { > struct drm_device *dev = crtc->base.dev; > struct drm_i915_private *dev_priv = dev->dev_private; > @@ -1778,7 +1776,7 @@ static void intel_enable_pipe(struct intel_crtc *crtc, > * need the check. > */ > if (!HAS_PCH_SPLIT(dev_priv->dev)) > - if (dsi) > + if (intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_DSI)) I think shovelling an is_dsi flag into pipe_config would make a lot of sense overall. Jani? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch