From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: unbind fbs from crtcs during driver unload Date: Tue, 11 Feb 2014 23:12:07 +0100 Message-ID: <20140211221207.GP17001@phenom.ffwll.local> References: <1392156070-32623-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 18FD6FAB5B for ; Tue, 11 Feb 2014 14:12:13 -0800 (PST) Received: by mail-wi0-f174.google.com with SMTP id f8so5511529wiw.13 for ; Tue, 11 Feb 2014 14:12:12 -0800 (PST) Content-Disposition: inline In-Reply-To: <1392156070-32623-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Feb 12, 2014 at 12:01:10AM +0200, Imre Deak wrote: > So far during driver unload we called drm_framebuffer_cleanup() for the > fbdev fb, which only removes the fb from the drm fb list regardless of > its reference count, but leaves the fb bound on an active crtc. Since > the fb's backing storage was freed this could mean we scan some random > memory content out afterwards. It's not a big issue since the fb is > allocated from stolen memory and afaik there is no other user for that > than i915. It's still cleaner to properly unbind the fb and disable the > crtc, which is what drm_framebuffer_remove() does. > > Note that after > > commit 88891eb1e9eca0ba619518bed31580f91e9cf84d > Author: Daniel Vetter > Date: Mon Feb 10 18:00:38 2014 +0100 > > we call drm_framebuffer_cleanup() only after dropping the last reference > on the fb, but that won't happen since we don't unbind the fb. This > results in a drm core warn about a leaked fb. > > Signed-off-by: Imre Deak Yeah, makes more sense. Apparently I really don't know my own fb lifetime rules :( Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_fbdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c > index cf46273..3a53ee3 100644 > --- a/drivers/gpu/drm/i915/intel_fbdev.c > +++ b/drivers/gpu/drm/i915/intel_fbdev.c > @@ -265,7 +265,7 @@ static void intel_fbdev_destroy(struct drm_device *dev, > drm_fb_helper_fini(&ifbdev->helper); > > drm_framebuffer_unregister_private(&ifbdev->fb->base); > - drm_framebuffer_unreference(&ifbdev->fb->base); > + drm_framebuffer_remove(&ifbdev->fb->base); > } > > int intel_fbdev_init(struct drm_device *dev) > -- > 1.8.3.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch