From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org, miku@iki.fi
Subject: Re: [PATCH 2/3] drm/i915: Record pid/comm of hanging task
Date: Wed, 12 Feb 2014 10:55:07 -0800 [thread overview]
Message-ID: <20140212185507.GA18418@bwidawsk.net> (raw)
In-Reply-To: <20140212081558.GB28999@nuc-i3427.alporthouse.com>
On Wed, Feb 12, 2014 at 08:15:58AM +0000, Chris Wilson wrote:
> On Tue, Feb 11, 2014 at 06:07:09PM -0800, Ben Widawsky wrote:
> > I still like my solution which does the strcpy on context creation. Your
> > solution is deferred in the usual case since the hangcheck is
> > asynchronous. The process could be long dead and gone.
>
> I disliked your solution since there was never a need to copy the string
> upon process creation, you could just have kept a reference to the
> pid...
>
> > Also, I think my solution is simpler, and with full PPGTT should get the
> > same information.
>
> I disagree that your solution was simpler and just introduced redundant
> storage.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
Are you opposed to doing anything at context creation? pid reference
works for me too, or hold on to it with the request - I don't care.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-02-12 18:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 14:30 [PATCH 1/3] drm/i915: Rely on accurate request tracking for finding hung batches Mika Kuoppala
2014-02-10 14:30 ` [PATCH 2/3] drm/i915: Record pid/comm of hanging task Mika Kuoppala
2014-02-12 2:07 ` Ben Widawsky
2014-02-12 8:15 ` Chris Wilson
2014-02-12 18:55 ` Ben Widawsky [this message]
2014-02-12 19:18 ` Chris Wilson
2014-02-12 19:32 ` Ben Widawsky
2014-03-05 13:08 ` Chris Wilson
2014-03-05 13:34 ` Daniel Vetter
2014-03-05 13:50 ` Chris Wilson
2014-02-10 14:30 ` [PATCH 3/3] drm/i915: Record error state capture reason Mika Kuoppala
2014-02-12 2:32 ` Ben Widawsky
2014-02-12 8:13 ` Chris Wilson
2014-02-12 19:05 ` Ben Widawsky
2014-02-12 1:57 ` [PATCH 1/3] drm/i915: Rely on accurate request tracking for finding hung batches Ben Widawsky
2014-02-12 8:25 ` Chris Wilson
2014-02-12 19:02 ` Ben Widawsky
2014-02-12 19:15 ` Chris Wilson
2014-02-12 17:47 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212185507.GA18418@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
--cc=miku@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox