From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 2/3] drm/i915: Record pid/comm of hanging task Date: Wed, 12 Feb 2014 10:55:07 -0800 Message-ID: <20140212185507.GA18418@bwidawsk.net> References: <1392042651-3278-1-git-send-email-mika.kuoppala@intel.com> <1392042651-3278-2-git-send-email-mika.kuoppala@intel.com> <20140212020708.GE23746@bwidawsk.net> <20140212081558.GB28999@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E702FAF59 for ; Wed, 12 Feb 2014 10:55:14 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140212081558.GB28999@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Mika Kuoppala , intel-gfx@lists.freedesktop.org, miku@iki.fi List-Id: intel-gfx@lists.freedesktop.org On Wed, Feb 12, 2014 at 08:15:58AM +0000, Chris Wilson wrote: > On Tue, Feb 11, 2014 at 06:07:09PM -0800, Ben Widawsky wrote: > > I still like my solution which does the strcpy on context creation. Your > > solution is deferred in the usual case since the hangcheck is > > asynchronous. The process could be long dead and gone. > > I disliked your solution since there was never a need to copy the string > upon process creation, you could just have kept a reference to the > pid... > > > Also, I think my solution is simpler, and with full PPGTT should get the > > same information. > > I disagree that your solution was simpler and just introduced redundant > storage. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre Are you opposed to doing anything at context creation? pid reference works for me too, or hold on to it with the request - I don't care. -- Ben Widawsky, Intel Open Source Technology Center