Re: [PATCH 2/3] drm/i915: Record pid/comm of hanging task

[Ben Widawsky <ben@bwidawsk.net>]

On Wed, Feb 12, 2014 at 07:18:19PM +0000, Chris Wilson wrote:
> On Wed, Feb 12, 2014 at 10:55:07AM -0800, Ben Widawsky wrote:
> > On Wed, Feb 12, 2014 at 08:15:58AM +0000, Chris Wilson wrote:
> > Are you opposed to doing anything at context creation? pid reference
> > works for me too, or hold on to it with the request - I don't care.
> 
> I'm just don't feel that the issue is severe enough for yet another pid
> reference floating around inside drm. I could well be wrong though, but
> I would like to be sure we have tried our best to use the available
> information we have already.
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

Well, the ref wouldn't be held if you just copied it at context create,
and it avoids having to stick in *file to actually do the proper look up
(not that that in itself is so horrible).

For the sake of making progress, I disagree with Chris in tbut think it's
better than what is currently there, so:
Acked-by: Ben Widawsky <ben@bwidawsk.net>

-- 
Ben Widawsky, Intel Open Source Technology Center