public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org,
	Sagar Kamble <sagar.a.kamble@intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/5] drm/i915: Full pipe rotation & rotation property name bikeshedding
Date: Thu, 13 Feb 2014 10:51:13 +0200	[thread overview]
Message-ID: <20140213085113.GI3891@intel.com> (raw)
In-Reply-To: <20140212231727.GH14909@nuc-i3427.alporthouse.com>

On Wed, Feb 12, 2014 at 11:17:27PM +0000, Chris Wilson wrote:
> On Wed, Feb 12, 2014 at 11:14:59PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > After playing around Sagar's primary plane rotation a bit, I decided that
> > extending that to full pipe rotation would be nice. Chris also seemed to
> > want that, but I'm not sure he does anymore :) But then I decided it's so
> > easy to implement that I can't leave it hanging. So here it is.
> 
> It would make the video sprite easier, as it would just work with a very
> minimal change. And it would make using the sprite easier for DRI window
> flips. I need to dig a bit as to find out how to fixup cursors I think.

Cursors should just work (tm) with full pipe rotation. You get into a
bit more trouble if you rotate just the cursor plane since then you get
to fix up the dst coordinates if your visible cursor is smaller than the
fixed cursor size. Or did you mean something else?

BTW if you want to try it, I pushed the lot to:
git://gitorious.org/vsyrjala/linux.git rotate_latest_2

-- 
Ville Syrjälä
Intel OTC

  reply	other threads:[~2014-02-13  8:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 21:14 [PATCH 0/5] drm/i915: Full pipe rotation & rotation property name bikeshedding ville.syrjala
2014-02-12 21:15 ` [PATCH 1/5] drm: Pass name to drm_rotation_property_create() ville.syrjala
2014-02-13 10:42   ` Sagar Arun Kamble
2014-02-12 21:15 ` [PATCH 2/5] drm/i915: Rename primary plane rotation property to "plane-rotation" ville.syrjala
2014-02-13 12:37   ` Sagar Arun Kamble
2014-02-13 13:46     ` Ville Syrjälä
2014-02-13 14:06       ` Ville Syrjälä
2014-02-13 14:20         ` [Intel-gfx] " Chris Wilson
2014-02-13 14:40           ` Ville Syrjälä
2014-02-12 21:15 ` [PATCH 3/5] drm: Add drm_rotation_chain() ville.syrjala
2014-02-12 21:15 ` [PATCH 4/5] drm/i915: Add rotation support for the cursor plane ville.syrjala
2014-02-14 11:01   ` Sagar Arun Kamble
2014-02-14 11:39     ` Ville Syrjälä
2014-02-17 17:23       ` Sagar Arun Kamble
2014-02-17 17:51         ` Ville Syrjälä
2014-02-18  7:49           ` Sagar Arun Kamble
2014-02-18  9:23             ` Ville Syrjälä
2014-02-18 10:09               ` Sagar Arun Kamble
2014-02-12 21:15 ` [PATCH 5/5] drm/i915: Add full pipe rotation ville.syrjala
2014-02-19 10:25   ` Sagar Arun Kamble
2014-02-12 23:17 ` [PATCH 0/5] drm/i915: Full pipe rotation & rotation property name bikeshedding Chris Wilson
2014-02-13  8:51   ` Ville Syrjälä [this message]
2014-02-13 11:20 ` Chris Wilson
2014-02-13 11:58   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140213085113.GI3891@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sagar.a.kamble@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox