From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 0/5] drm/i915: Full pipe rotation & rotation
 property name bikeshedding
Date: Thu, 13 Feb 2014 10:51:13 +0200
Message-ID: <20140213085113.GI3891@intel.com>
References: <1392239704-21776-1-git-send-email-ville.syrjala@linux.intel.com>
	<20140212231727.GH14909@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20140212231727.GH14909@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org, Sagar Kamble <sagar.a.kamble@intel.com>, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Feb 12, 2014 at 11:17:27PM +0000, Chris Wilson wrote:
> On Wed, Feb 12, 2014 at 11:14:59PM +0200, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > After playing around Sagar's primary plane rotation a bit, I decided th=
at
> > extending that to full pipe rotation would be nice. Chris also seemed to
> > want that, but I'm not sure he does anymore :) But then I decided it's =
so
> > easy to implement that I can't leave it hanging. So here it is.
> =

> It would make the video sprite easier, as it would just work with a very
> minimal change. And it would make using the sprite easier for DRI window
> flips. I need to dig a bit as to find out how to fixup cursors I think.

Cursors should just work (tm) with full pipe rotation. You get into a
bit more trouble if you rotate just the cursor plane since then you get
to fix up the dst coordinates if your visible cursor is smaller than the
fixed cursor size. Or did you mean something else?

BTW if you want to try it, I pushed the lot to:
git://gitorious.org/vsyrjala/linux.git rotate_latest_2

-- =

Ville Syrj=E4l=E4
Intel OTC