public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ben Widawsky <benjamin.widawsky@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 0/9] [REPOST] BDW 4G GGTT + PPGTT cleanups
Date: Thu, 13 Feb 2014 13:47:57 +0200	[thread overview]
Message-ID: <20140213114757.GL3891@intel.com> (raw)
In-Reply-To: <1392244132-6806-1-git-send-email-benjamin.widawsky@intel.com>

On Wed, Feb 12, 2014 at 02:28:43PM -0800, Ben Widawsky wrote:
> Rebased series from what I submitted a while ago:
> http://lists.freedesktop.org/archives/intel-gfx/2013-December/037815.html
> 
> It was mostly a clean rebase, but there were a couple of major conflicts which
> I think I cleaned up properly, but extra eyes would be good.

One thing I noticed while staring at the ppgtt code recently is that
gen6 ppgtt cleanup kfrees the ppgtt struct, but gen8 code doesn't.
At that time it looked like the correct fix was moving the kfree()
out from the gen6 code into some common place. The reason being
that the gen8 code called the cleanup function during error handling
in the init paths. But I'm not sure if you've changed that with this
series. A quick scan of these patches tells me the leak is still
there at least.

> 
> As before, the last two are optional.
> 
> Ben Widawsky (9):
>   drm/i915/bdw: Split up PPGTT cleanup
>   drm/i915/bdw: Reorganize PPGTT init
>   drm/i915/bdw: Split ppgtt initialization up
>   drm/i915: Make clear/insert vfuncs args absolute
>   drm/i915/bdw: Reorganize PT allocations
>   Revert "drm/i915/bdw: Limit GTT to 2GB"
>   drm/i915: Update i915_gem_gtt.c copyright
>   drm/i915: Split GEN6 PPGTT cleanup
>   drm/i915: Split GEN6 PPGTT initialization up
> 
>  drivers/gpu/drm/i915/i915_drv.h     |  13 +-
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 621 +++++++++++++++++++++++++-----------
>  2 files changed, 438 insertions(+), 196 deletions(-)
> 
> -- 
> 1.8.5.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

  parent reply	other threads:[~2014-02-13 11:48 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <to=1387921357-22942-1-git-send-email-benjamin.widawsky@intel.com>
2014-02-12 22:28 ` [PATCH 0/9] [REPOST] BDW 4G GGTT + PPGTT cleanups Ben Widawsky
2014-02-12 22:28   ` [PATCH 1/9] drm/i915/bdw: Split up PPGTT cleanup Ben Widawsky
2014-02-13 10:40     ` Chris Wilson
2014-02-12 22:28   ` [PATCH 2/9] drm/i915/bdw: Reorganize PPGTT init Ben Widawsky
2014-02-19 14:59     ` Imre Deak
2014-02-19 20:06       ` [PATCH] [v3] " Ben Widawsky
2014-02-19 21:00         ` Imre Deak
2014-02-19 21:18           ` Ben Widawsky
2014-02-12 22:28   ` [PATCH 3/9] drm/i915/bdw: Split ppgtt initialization up Ben Widawsky
2014-02-19 17:03     ` Imre Deak
2014-02-12 22:28   ` [PATCH 4/9] drm/i915: Make clear/insert vfuncs args absolute Ben Widawsky
2014-02-13  0:14     ` Chris Wilson
2014-02-13  0:34       ` Ben Widawsky
2014-02-19 17:26     ` Imre Deak
2014-02-12 22:28   ` [PATCH 5/9] drm/i915/bdw: Reorganize PT allocations Ben Widawsky
2014-02-12 23:45     ` Chris Wilson
2014-02-12 23:52       ` Ben Widawsky
2014-02-19 19:11     ` Imre Deak
2014-02-19 19:25       ` Imre Deak
2014-02-19 21:06       ` Ben Widawsky
2014-02-19 21:20         ` Imre Deak
2014-02-19 21:31           ` Ben Widawsky
2014-02-12 22:28   ` [PATCH 6/9] Revert "drm/i915/bdw: Limit GTT to 2GB" Ben Widawsky
2014-02-19 19:14     ` Imre Deak
2014-02-12 22:28   ` [PATCH 7/9] drm/i915: Update i915_gem_gtt.c copyright Ben Widawsky
2014-02-12 23:19     ` Damien Lespiau
2014-02-12 23:22       ` Ben Widawsky
2014-02-19 19:20     ` Imre Deak
2014-02-12 22:28   ` [PATCH 8/9] drm/i915: Split GEN6 PPGTT cleanup Ben Widawsky
2014-02-13 10:29     ` Chris Wilson
2014-02-12 22:28   ` [PATCH 9/9] drm/i915: Split GEN6 PPGTT initialization up Ben Widawsky
2014-02-13 10:33     ` Chris Wilson
2014-02-13 11:47   ` Ville Syrjälä [this message]
2014-02-19 17:17     ` [PATCH 0/9] [REPOST] BDW 4G GGTT + PPGTT cleanups Ben Widawsky
2014-02-20  6:05   ` [PATCH 0/9] [v2] " Ben Widawsky
2014-02-21 21:06     ` [PATCH 10/9] drm/i915/bdw: Kill ppgtt->num_pt_pages Ben Widawsky
2014-02-24 17:17       ` Imre Deak
2014-03-04 15:42         ` Daniel Vetter
2014-03-04 14:50     ` [PATCH 0/9] [v2] BDW 4G GGTT + PPGTT cleanups Daniel Vetter
2014-02-20  6:05   ` [PATCH 1/9] drm/i915/bdw: Free PPGTT struct Ben Widawsky
2014-02-20  9:31     ` Imre Deak
2014-02-20 19:47     ` [PATCH .5/9] drm/i915: Move ppgtt_release out of the header Ben Widawsky
2014-02-20 19:47       ` [PATCH 1/9] [v2] drm/i915/bdw: Free PPGTT struct Ben Widawsky
2014-02-24 16:43         ` Imre Deak
2014-02-24 16:18       ` [PATCH .5/9] drm/i915: Move ppgtt_release out of the header Imre Deak
2014-03-04 14:53       ` Daniel Vetter
2014-02-20  6:05   ` [PATCH 2/9] drm/i915/bdw: Reorganize PPGTT init Ben Widawsky
2014-02-20  6:05   ` [PATCH 3/9] drm/i915/bdw: Split ppgtt initialization up Ben Widawsky
2014-02-20 13:10     ` Imre Deak
2014-02-20  6:05   ` [PATCH 4/9] drm/i915: Make clear/insert vfuncs args absolute Ben Widawsky
2014-02-20 10:37     ` Imre Deak
2014-02-20 19:35       ` Ben Widawsky
2014-02-20 19:50     ` [PATCH 4/9] [v3] " Ben Widawsky
2014-02-24 16:52       ` Imre Deak
2014-02-20  6:05   ` [PATCH 5/9] drm/i915/bdw: Reorganize PT allocations Ben Widawsky
2014-02-20 11:28     ` Imre Deak
2014-02-20 19:51     ` [PATCH 5/9] [v5] " Ben Widawsky
2014-02-24 17:03       ` Imre Deak
2014-02-24 23:38         ` Ben Widawsky
2014-02-20  6:05   ` [PATCH 6/9] Revert "drm/i915/bdw: Limit GTT to 2GB" Ben Widawsky
2014-02-20  6:05   ` [PATCH 7/9] drm/i915: Update i915_gem_gtt.c copyright Ben Widawsky
2014-02-20  6:05   ` [PATCH 8/9] drm/i915: Split GEN6 PPGTT cleanup Ben Widawsky
2014-02-20  6:05   ` [PATCH 9/9] drm/i915: Split GEN6 PPGTT initialization up Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140213114757.GL3891@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=benjamin.widawsky@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox