From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/lvds: Remove dead code from failing case
Date: Thu, 13 Feb 2014 21:11:38 +0100 [thread overview]
Message-ID: <20140213201138.GD17001@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGQpzS3q_89QMAYgeBOaTJDgxsr37dVcnBOByk38T=YVpw@mail.gmail.com>
On Thu, Feb 13, 2014 at 05:04:48PM -0200, Paulo Zanoni wrote:
> 2014-02-13 16:56 GMT-02:00 Damien Lespiau <damien.lespiau@intel.com>:
> > Coverity points out that, if we end up in the 'failed' label, that's
> > precisely because we couldn't retrieve a fixed mode (ie fixed_mode is
> > NULL) and then "if (fixed_mode)" is always false.
> >
> > Remove that dead code.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-02-13 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 18:56 [PATCH] drm/i915/lvds: Remove dead code from failing case Damien Lespiau
2014-02-13 19:04 ` Paulo Zanoni
2014-02-13 20:11 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213201138.GD17001@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox