From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915/lvds: Remove dead code from
 failing case
Date: Thu, 13 Feb 2014 21:11:38 +0100
Message-ID: <20140213201138.GD17001@phenom.ffwll.local>
References: <1392317775-20113-1-git-send-email-damien.lespiau@intel.com>
	<CA+gsUGQpzS3q_89QMAYgeBOaTJDgxsr37dVcnBOByk38T=YVpw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45])
	by gabe.freedesktop.org (Postfix) with ESMTP id 98CF0FAD9E
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Feb 2014 12:11:43 -0800 (PST)
Received: by mail-ee0-f45.google.com with SMTP id b15so5256060eek.4
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Feb 2014 12:11:42 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CA+gsUGQpzS3q_89QMAYgeBOaTJDgxsr37dVcnBOByk38T=YVpw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Feb 13, 2014 at 05:04:48PM -0200, Paulo Zanoni wrote:
> 2014-02-13 16:56 GMT-02:00 Damien Lespiau <damien.lespiau@intel.com>:
> > Coverity points out that, if we end up in the 'failed' label, that's
> > precisely because we couldn't retrieve a fixed mode (ie fixed_mode is
> > NULL) and then "if (fixed_mode)" is always false.
> >
> > Remove that dead code.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch