From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 4/9] drm/i915/bdw: Use centralized rc6 info
 print
Date: Mon, 17 Feb 2014 11:41:41 -0800
Message-ID: <20140217194141.GA19622@bwidawsk.net>
References: <1390969547-1018-1-git-send-email-benjamin.widawsky@intel.com>
	<1390969547-1018-5-git-send-email-benjamin.widawsky@intel.com>
	<CABVU7+un+eCpBCnJO=Gw+uKPwPR=R461uZrM5Gcg+RzwiYeXPg@mail.gmail.com>
	<20140211161217.GN17001@phenom.ffwll.local>
	<20140214203422.GA30028@bwidawsk.net>
	<20140214204108.GO32602@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id C9E5EFA834
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 17 Feb 2014 11:41:58 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20140214204108.GO32602@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel@ffwll.ch>, Rodrigo Vivi <rodrigo.vivi@gmail.com>, Ben Widawsky <benjamin.widawsky@intel.com>, intel-gfx@freedesktop.org, Intel GFX <intel-gfx@lists.freedesktop.org>, Jesse Barnes <jbarnes@virtuousgeek.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Feb 14, 2014 at 08:41:08PM +0000, Chris Wilson wrote:
> On Fri, Feb 14, 2014 at 12:34:22PM -0800, Ben Widawsky wrote:
> > On Tue, Feb 11, 2014 at 05:12:17PM +0100, Daniel Vetter wrote:
> > > - 6/9 lacks review ...
> > > 
> > 
> > 6/9 can be skipped for this series, though I think it's a reasonable
> > patch. Maybe Chris or Jesse has an opinion on 6/9?
> 
> Yes, programming random values into the hardware is just bonghits. And
> then people come along complaining how the idiotic programming guide is
> sacrosanct and must be adherred to...
> 
> Otoh, changing the value of GEN6_RC_VIDEO_FREQ is worrying as we never
> reprogram it nor have I come across any instructions as to what it does.
> -Chris

Can I take a _____by: if I drop GEN6_RC_VIDEO_FREQ?

> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

-- 
Ben Widawsky, Intel Open Source Technology Center