From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 9/9] drm/i915/bdw: Enable RC6
Date: Mon, 17 Feb 2014 12:04:19 -0800
Message-ID: <20140217200419.GC19622@bwidawsk.net>
References: <1390969547-1018-1-git-send-email-benjamin.widawsky@intel.com>
	<1390969547-1018-11-git-send-email-benjamin.widawsky@intel.com>
	<CABVU7+v8p0Wti4KyKcbf-ZUtfPmcN2LVpDBukqww+DeTtv7h0g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <CABVU7+v8p0Wti4KyKcbf-ZUtfPmcN2LVpDBukqww+DeTtv7h0g@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@freedesktop.org, Intel GFX <intel-gfx@lists.freedesktop.org>, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Feb 06, 2014 at 11:54:44AM -0200, Rodrigo Vivi wrote:
> On Wed, Jan 29, 2014 at 2:25 AM, Ben Widawsky
> <benjamin.widawsky@intel.com> wrote:
> > It is tested and looking fairly stable now, so turn it on. It wasn't
> > intentionally turned off originally :P
> >
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > ---
> >  drivers/gpu/drm/i915/intel_pm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index a5c9142..377bd7f 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -4428,7 +4428,7 @@ void intel_enable_gt_powersave(struct drm_device *dev)
> >                 ironlake_enable_drps(dev);
> >                 ironlake_enable_rc6(dev);
> >                 intel_init_emon(dev);
> > -       } else if (IS_GEN6(dev) || IS_GEN7(dev)) {
> > +       } else if (IS_GEN6(dev) || IS_GEN7(dev) || IS_BROADWELL(dev)) {
> 
> why not IS_GEN8?
> or why not use gen >= gen6?
> 
> anyway: Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> 

This is my personal preference, though we have some ongoing discussions
in this area. I do not like to explicitly add support for future
platforms except for the most trivial things. I don't think everyone
agrees with me.

Anyway, thanks for the review. I'll be resending the series with a
fairly trivial, though large change.

> 
> 
> 
> -- 
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br

-- 
Ben Widawsky, Intel Open Source Technology Center