From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 13/19] drm/i915: factor out reset_vblank_counter Date: Tue, 18 Feb 2014 18:55:13 +0200 Message-ID: <20140218165513.GW3852@intel.com> References: <1392674540-10915-1-git-send-email-imre.deak@intel.com> <1392674540-10915-14-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id A66FCFA1B3 for ; Tue, 18 Feb 2014 08:55:42 -0800 (PST) Content-Disposition: inline In-Reply-To: <1392674540-10915-14-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Feb 18, 2014 at 12:02:14AM +0200, Imre Deak wrote: > We need to do the same for other platforms in upcoming patches. > = > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_pm.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index 9cb7ed6..e81e7de 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -5249,11 +5249,19 @@ static void hsw_power_well_post_enable(struct drm= _i915_private *dev_priv) > } > } > = > +static void reset_vblank_counter(struct drm_device *dev, enum pipe p) Could just call the parameter 'pipe' while we're at it. > +{ > + unsigned long irqflags; > + > + spin_lock_irqsave(&dev->vbl_lock, irqflags); > + dev->vblank[p].last =3D 0; > + spin_unlock_irqrestore(&dev->vbl_lock, irqflags); > +} > + > static void hsw_power_well_post_disable(struct drm_i915_private *dev_pri= v) > { > struct drm_device *dev =3D dev_priv->dev; > enum pipe p; > - unsigned long irqflags; > = > /* > * After this, the registers on the pipes that are part of the power > @@ -5262,11 +5270,9 @@ static void hsw_power_well_post_disable(struct drm= _i915_private *dev_priv) > * > * FIXME: Should we do this in general in drm_vblank_post_modeset? > */ > - spin_lock_irqsave(&dev->vbl_lock, irqflags); > for_each_pipe(p) > if (p !=3D PIPE_A) > - dev->vblank[p].last =3D 0; > - spin_unlock_irqrestore(&dev->vbl_lock, irqflags); > + reset_vblank_counter(dev, p); > } > = > static void hsw_set_power_well(struct drm_i915_private *dev_priv, > -- = > 1.8.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC