From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff* Date: Sat, 22 Feb 2014 11:40:43 -0800 Message-ID: <20140222194043.GC1209@bwidawsk.net> References: <1390969547-1018-2-git-send-email-benjamin.widawsky@intel.com> <1392692512-2268-1-git-send-email-benjamin.widawsky@intel.com> <1392692512-2268-4-git-send-email-benjamin.widawsky@intel.com> <20140222133716.GS17020@nuc-i3427.alporthouse.com> <20140222193415.GA1209@bwidawsk.net> <20140222193704.GT17020@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 26824FA48E for ; Sat, 22 Feb 2014 11:40:49 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140222193704.GT17020@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Sat, Feb 22, 2014 at 07:37:04PM +0000, Chris Wilson wrote: > On Sat, Feb 22, 2014 at 11:34:16AM -0800, Ben Widawsky wrote: > > On Sat, Feb 22, 2014 at 01:37:16PM +0000, Chris Wilson wrote: > > > On Mon, Feb 17, 2014 at 07:01:44PM -0800, Ben Widawsky wrote: > > > > The names of the struct members for RPS are stupid. Every time I need to > > > > do anything in this code I have to spend a significant amount of time to > > > > remember what it all means. By renaming the variables (and adding the > > > > comments) I hope to clear up the situation. Indeed doing this make some > > > > upcoming patches more readable. > > > > > > > > I've avoided ILK because it's possible that the naming used for Ironlake > > > > matches what is in the docs. I believe the ILK power docs were never > > > > published, and I am too lazy to dig them up. > > > > > > > > While there may be mistakes, this patch was mostly done via sed. The > > > > renaming of "hw_max" required a bit of interactivity. > > > > > > It lost the distinction between RPe and RPn. I am in favour of keeping > > > RP0, RP1, RPe, RPn for the hardware/spec values and adding the set of > > > soft values used for actual interaction. > > > -Chris > > > > > > > And what is the difference between RPe, and RPn? I honestly have no clue > > what RPe is. > > It's a mythical beast on Valleyview for an inflection point in the > power/performance curve that the hardware designers recommend using. > -Chris > Isn't that exactly what RPn is supposed to be? -- Ben Widawsky, Intel Open Source Technology Center