From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: use backlight legacy combination
 mode also for i915gm/i945gm
Date: Wed, 26 Feb 2014 15:20:43 +0200
Message-ID: <20140226132042.GE3852@intel.com>
References: <20140225104738.GW3852@intel.com>
	<1393326707-917-1-git-send-email-jani.nikula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id AB557FAA4B
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 26 Feb 2014 05:20:47 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1393326707-917-1-git-send-email-jani.nikula@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, luiorpe1@gmail.com
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Feb 25, 2014 at 01:11:47PM +0200, Jani Nikula wrote:
> i915gm and i945gm also seem to use and need the legacy combination mode
> bit in BLC_PWM_CTL.
> =

> v2: Also do this for i915gm (Ville).
> =

> Reported-and-tested-by: Luis Ortega <luiorpe1@gmail.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D75001
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Looks sane enough for me.

Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_panel.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> =

> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/in=
tel_panel.c
> index 5bc3f6ea1014..cb058408c70e 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -689,7 +689,7 @@ static void i9xx_enable_backlight(struct intel_connec=
tor *connector)
>  		freq /=3D 0xff;
>  =

>  	ctl =3D freq << 17;
> -	if (IS_GEN2(dev) && panel->backlight.combination_mode)
> +	if (panel->backlight.combination_mode)
>  		ctl |=3D BLM_LEGACY_MODE;
>  	if (IS_PINEVIEW(dev) && panel->backlight.active_low_pwm)
>  		ctl |=3D BLM_POLARITY_PNV;
> @@ -970,7 +970,7 @@ static int i9xx_setup_backlight(struct intel_connecto=
r *connector)
>  =

>  	ctl =3D I915_READ(BLC_PWM_CTL);
>  =

> -	if (IS_GEN2(dev))
> +	if (IS_GEN2(dev) || IS_I915GM(dev) || IS_I945GM(dev))
>  		panel->backlight.combination_mode =3D ctl & BLM_LEGACY_MODE;
>  =

>  	if (IS_PINEVIEW(dev))
> -- =

> 1.7.9.5

-- =

Ville Syrj=E4l=E4
Intel OTC