From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Kenneth Graunke <kenneth@whitecape.org>
Cc: intel-gfx@lists.freedesktop.org, ben@bwidawsk.net
Subject: Re: [PATCH 2/2] drm/i915: Add thread stall DOP clock gating workaround on Broadwell.
Date: Thu, 27 Feb 2014 11:08:24 +0200 [thread overview]
Message-ID: <20140227090824.GJ3852@intel.com> (raw)
In-Reply-To: <20140227084333.GH3852@intel.com>
On Thu, Feb 27, 2014 at 10:43:34AM +0200, Ville Syrjälä wrote:
> On Wed, Feb 26, 2014 at 11:59:31PM -0800, Kenneth Graunke wrote:
> > Ben and I believe this will be necessary on production hardware.
> >
> > Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 1 +
> > drivers/gpu/drm/i915/intel_pm.c | 4 ++++
> > 2 files changed, 5 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index f36d5e0..ade1d71 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -5052,6 +5052,7 @@
> >
> > #define GEN8_ROW_CHICKEN 0xe4f0
> > #define PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE (1<<8)
> > +#define STALL_DOP_GATING_DISABLE (1<<5)
> >
> > #define GEN7_ROW_CHICKEN2 0xe4f4
> > #define GEN7_ROW_CHICKEN2_GT2 0xf4f4
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index df8ad21..226591d 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -4842,6 +4842,10 @@ static void gen8_init_clock_gating(struct drm_device *dev)
> > I915_WRITE(GEN8_ROW_CHICKEN,
> > _MASKED_BIT_ENABLE(PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE));
> >
> > + /* WaDisableThreadStallDopClockGating:bdw */
> > + I915_WRITE(GEN8_ROW_CHICKEN,
> > + _MASKED_BIT_ENABLE(STALL_DOP_GATING_DISABLE));
>
> The spec and w/a database are a bit confused on this, but I get the
> impression that you're correct. So:
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Actually I might have to take that back a bit. Looks more like it
shouldn't be needed for production hardware, but I'm guessing people
currently have hardware that needs it, so we should have it at least
for now.
>
> > +
> > /*
> > * This GEN8_CENTROID_PIXEL_OPT_DIS W/A is only needed for
> > * pre-production hardware
> > --
> > 1.8.4.2
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel OTC
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-02-27 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 7:59 [PATCH 1/2] drm/i915: Add a partial instruction shootdown workaround on Broadwell Kenneth Graunke
2014-02-27 7:59 ` [PATCH 2/2] drm/i915: Add thread stall DOP clock gating " Kenneth Graunke
2014-02-27 8:43 ` Ville Syrjälä
2014-02-27 9:08 ` Ville Syrjälä [this message]
2014-02-27 8:43 ` [PATCH 1/2] drm/i915: Add a partial instruction shootdown " Ville Syrjälä
2014-02-28 0:05 ` Ben Widawsky
2014-03-05 14:48 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227090824.GJ3852@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox