From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 15/23] drm/i915: don't get/put PC8 reference
 on freeze/thaw
Date: Fri, 28 Feb 2014 09:11:52 -0800
Message-ID: <20140228091152.1383e7eb@jbarnes-desktop>
References: <1393540010-1582-1-git-send-email-przanoni@gmail.com>
	<1393540010-1582-16-git-send-email-przanoni@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from alt-proxy12.mail.unifiedlayer.com
	(alt-proxy12.mail.unifiedlayer.com [67.20.64.47])
	by gabe.freedesktop.org (Postfix) with SMTP id 27342FBC74
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 28 Feb 2014 09:18:07 -0800 (PST)
In-Reply-To: <1393540010-1582-16-git-send-email-przanoni@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 27 Feb 2014 19:26:42 -0300
Paulo Zanoni <przanoni@gmail.com> wrote:

> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> We already get runtime PM references, and PC8 is now part of runtime
> PM, so this is enough.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 983ab56..7a8b86e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -433,7 +433,6 @@ static int i915_drm_freeze(struct drm_device *dev)
>  
>  	/* We do a lot of poking in a lot of registers, make sure they work
>  	 * properly. */
> -	hsw_disable_package_c8(dev_priv);
>  	intel_display_set_init_power(dev, true);
>  
>  	drm_kms_helper_poll_disable(dev);
> @@ -606,10 +605,6 @@ static int __i915_drm_thaw(struct drm_device *dev, bool restore_gtt_mappings)
>  		schedule_work(&dev_priv->console_resume_work);
>  	}
>  
> -	/* Undo what we did at i915_drm_freeze so the refcount goes back to the
> -	 * expected level. */
> -	hsw_enable_package_c8(dev_priv);
> -
>  	mutex_lock(&dev_priv->modeset_restore_lock);
>  	dev_priv->modeset_restore = MODESET_DONE;
>  	mutex_unlock(&dev_priv->modeset_restore_lock);

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center