From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 21/23] drm/i915: rename __hsw_do_{en, dis}able_pc8 Date: Fri, 28 Feb 2014 09:17:00 -0800 Message-ID: <20140228091700.588d786e@jbarnes-desktop> References: <1393540010-1582-1-git-send-email-przanoni@gmail.com> <1393540010-1582-22-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from qproxy1-pub.mail.unifiedlayer.com (qproxy1-pub.mail.unifiedlayer.com [173.254.64.10]) by gabe.freedesktop.org (Postfix) with SMTP id 1272BFB792 for ; Fri, 28 Feb 2014 09:16:35 -0800 (PST) In-Reply-To: <1393540010-1582-22-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Thu, 27 Feb 2014 19:26:48 -0300 Paulo Zanoni wrote: > From: Paulo Zanoni > > After we removed all the intermediate abstractions, we can rename > these functions to just hsw_{en,dis}able_pc8. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/i915_drv.c | 4 ++-- > drivers/gpu/drm/i915/intel_display.c | 4 ++-- > drivers/gpu/drm/i915/intel_drv.h | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 7a8b86e..88ea6ce 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -846,7 +846,7 @@ static int i915_runtime_suspend(struct device *device) > DRM_DEBUG_KMS("Suspending device\n"); > > if (HAS_PC8(dev)) > - __hsw_do_enable_pc8(dev_priv); > + hsw_enable_pc8(dev_priv); > > i915_gem_release_all_mmaps(dev_priv); > > @@ -880,7 +880,7 @@ static int i915_runtime_resume(struct device *device) > dev_priv->pm.suspended = false; > > if (HAS_PC8(dev)) > - __hsw_do_disable_pc8(dev_priv); > + hsw_disable_pc8(dev_priv); > > DRM_DEBUG_KMS("Device resumed\n"); > return 0; > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 420fad5..c981e63 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -6651,7 +6651,7 @@ static void hsw_restore_lcpll(struct drm_i915_private *dev_priv) > gen6_gt_force_wake_put_no_rpm(dev_priv, FORCEWAKE_ALL); > } > > -void __hsw_do_enable_pc8(struct drm_i915_private *dev_priv) > +void hsw_enable_pc8(struct drm_i915_private *dev_priv) > { > struct drm_device *dev = dev_priv->dev; > uint32_t val; > @@ -6671,7 +6671,7 @@ void __hsw_do_enable_pc8(struct drm_i915_private *dev_priv) > hsw_disable_lcpll(dev_priv, true, true); > } > > -void __hsw_do_disable_pc8(struct drm_i915_private *dev_priv) > +void hsw_disable_pc8(struct drm_i915_private *dev_priv) > { > struct drm_device *dev = dev_priv->dev; > uint32_t val; > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index d0434e8..288f531 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -720,8 +720,8 @@ unsigned long intel_gen4_compute_page_offset(int *x, int *y, > unsigned int bpp, > unsigned int pitch); > void intel_display_handle_reset(struct drm_device *dev); > -void __hsw_do_enable_pc8(struct drm_i915_private *dev_priv); > -void __hsw_do_disable_pc8(struct drm_i915_private *dev_priv); > +void hsw_enable_pc8(struct drm_i915_private *dev_priv); > +void hsw_disable_pc8(struct drm_i915_private *dev_priv); > void intel_dp_get_m_n(struct intel_crtc *crtc, > struct intel_crtc_config *pipe_config); > int intel_dotclock_calculate(int link_freq, const struct intel_link_m_n *m_n); Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center