From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] drm/i915: Convert the forcewake worker into a timer func Date: Sun, 2 Mar 2014 17:01:26 -0800 Message-ID: <20140303010126.GA946@bwidawsk.net> References: <20140228091633.GO3852@intel.com> <1393613043-23213-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C568FAE91 for ; Sun, 2 Mar 2014 17:01:51 -0800 (PST) Content-Disposition: inline In-Reply-To: <1393613043-23213-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMjgsIDIwMTQgYXQgMDY6NDQ6MDNQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFdlIGRvbid0IHdhbnQgdG8gc3VmZmVyIHNjaGVkdWxpbmcgZGVsYXkgd2hlbiB0dXJu aW5nIG9mZiB0aGUgR1BVIGFmdGVyCj4gd2FraW5nIGl0IHVwIHRvIHRvdWNoIHJlZ2lzdGVycy4g SWRlYWxseSwgd2Ugb25seSB3YW50IHRvIGtlZXAgdGhlIEdQVQo+IGF3YWtlIGZvciB0aGUgcmVn aXN0ZXIgYWNjZXNzIHNlcXVlbmNlLCB3aXRoIGEgc2luZ2xlIGZvcmNld2FrZSBkYW5jZSBvbgo+ IHRoZSBmaXJzdCBhY2Nlc3MgYW5kIHJlbGVhc2UgaW1tZWRpYXRlbHkgYWZ0ZXIgdGhlIGxhc3Qu IFdlIHNldCBhIHRpbWVyCj4gb24gdGhlIGZpcnN0IGFjY2VzcyBzbyB0aGF0IHdlIG9ubHkgZGFu Y2Ugb25jZSBhbmQgb24gdGhlIG5leHQgc2NoZWR1bGVyCj4gdGljaywgd2UgZHJvcCB0aGUgZm9y Y2V3YWtlIGFnYWluLgo+IAo+IFRoaXMgbW92ZXMgdGhlIGNsZWFudXAgcm91dGluZSBmcm9tIHRo ZSBjb21tb24gaTkxNSB3b3JrcXVldWUgdG8gYSB0aW1lcgo+IGZ1bmMgc28gdGhhdCB3ZSBkb24n dCBhbmdlciBwb3dlcnRvcCwgYW5kIGRyb3AgdGhlIGZvcmNld2FrZSBhZ2Fpbgo+IHF1aWNrZXIu Cj4gCj4gdjI6IEVuYWJsZSB0aGUgZGVmZXJyZWQgZm9yY2Vfd2FrZV9wdXQgZm9yIHJlZ3VsYXIg cmVnaXN0ZXIgcmVhZHMgYXMKPiB3ZWxsLgoKU28gSSB3ZW50IHRvIHRlc3QgdGhpcyBwYXRjaCB0 b2RheS4gT2RkbHkgdGhpcyBpc24ndCBzaG93aW5nIHVwIGluIGFueQpvZiBteSBwcm9maWxlcyBv biB0aGUgbGF0ZXN0IGRybS1pbnRlbC1uaWdodGx5LiBJIGp1c3QgdGVzdGVkIHRvZGF5LCBhbmQK RGFuaWVsIG1hZGUgaXQgYSAzLjE0LXJjNCBiYXNlZCB0aGluZyB0b2RheS4gSXQgd2FzIHN0aWxs IHByZXNlbnQgb24KMy4xMy4wLiBBY3R1YWxseSwgaTkxNV9nZW1fcmV0aXJlX3dvcmtfaGFuZGxl ciBpcyB0aGUgb25seSBvbmUgZXZlbgpzaG93aW5nIHVwIGluIHBvd2VydG9wLCB3aGljaCBpcyBo b3cgaXQgc2hvdWxkIGJlIElNTy4KClRoZXJlZm9yZSBJJ20gbm90IHN1cmUgd2hhdCB3ZSBzaG91 bGQgZG8gd2l0aCB0aGlzLgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlz QGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogQmVuIFdpZGF3c2t5IDxiZW5AYndpZGF3c2submV0 Pgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICB8ICAyICstCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIHwgMzQgKysrKysrKysrKysrKysrLS0t LS0tLS0tLS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDIw IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4IGIyMjc2NTE5 MjAxOC4uOGFmOGUwZGQzOTQzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTUw OCw3ICs1MDgsNyBAQCBzdHJ1Y3QgaW50ZWxfdW5jb3JlIHsKPiAgCXVuc2lnbmVkIGZ3X3JlbmRl cmNvdW50Owo+ICAJdW5zaWduZWQgZndfbWVkaWFjb3VudDsKPiAgCj4gLQlzdHJ1Y3QgZGVsYXll ZF93b3JrIGZvcmNlX3dha2Vfd29yazsKPiArCXN0cnVjdCB0aW1lcl9saXN0IGZvcmNlX3dha2Vf dGltZXI7Cj4gIH07Cj4gIAo+ICAjZGVmaW5lIERFVl9JTkZPX0ZPUl9FQUNIX0ZMQUcoZnVuYywg c2VwKSBcCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiBpbmRleCBjNjI4NDE0MDRj ODIuLjhlZTE3MTE3OGJmZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF91bmNvcmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4g QEAgLTI4OSwxMCArMjg5LDggQEAgdm9pZCB2bHZfZm9yY2Vfd2FrZV9wdXQoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2X3By aXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGdlbjZf Zm9yY2Vfd2FrZV93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiArc3RhdGljIHZvaWQg Z2VuNl9mb3JjZV93YWtlX3RpbWVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiAgewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0KPiAtCQljb250YWlu ZXJfb2Yod29yaywgdHlwZW9mKCpkZXZfcHJpdiksIHVuY29yZS5mb3JjZV93YWtlX3dvcmsud29y ayk7Cj4gIAl1bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+ICAKPiAgCXNwaW5fbG9ja19pcnFzYXZl KCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsKPiBAQCAtNDA1LDkgKzQwMyw4IEBA IHZvaWQgZ2VuNl9ndF9mb3JjZV93YWtlX3B1dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsIGludCBmd19lbmdpbmUpCj4gIAlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3ByaXYtPnVu Y29yZS5sb2NrLCBpcnFmbGFncyk7Cj4gIAlpZiAoLS1kZXZfcHJpdi0+dW5jb3JlLmZvcmNld2Fr ZV9jb3VudCA9PSAwKSB7Cj4gIAkJZGV2X3ByaXYtPnVuY29yZS5mb3JjZXdha2VfY291bnQrKzsK PiAtCQltb2RfZGVsYXllZF93b3JrKGRldl9wcml2LT53cSwKPiAtCQkJCSAmZGV2X3ByaXYtPnVu Y29yZS5mb3JjZV93YWtlX3dvcmssCj4gLQkJCQkgMSk7Cj4gKwkJbW9kX3RpbWVyX3Bpbm5lZCgm ZGV2X3ByaXYtPnVuY29yZS5mb3JjZV93YWtlX3RpbWVyLAo+ICsJCQkJIGppZmZpZXMgKyAxKTsK PiAgCX0KPiAgCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9jaywg aXJxZmxhZ3MpOwo+ICAKPiBAQCAtNDg0LDE3ICs0ODEsMTUgQEAgZ2VuNV9yZWFkIyN4KHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgb2ZmX3QgcmVnLCBib29sIHRyYWNlKSB7IFwK PiAgc3RhdGljIHUjI3ggXAo+ICBnZW42X3JlYWQjI3goc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LCBvZmZfdCByZWcsIGJvb2wgdHJhY2UpIHsgXAo+ICAJUkVHX1JFQURfSEVBREVS KHgpOyBcCj4gLQlpZiAoTkVFRFNfRk9SQ0VfV0FLRSgoZGV2X3ByaXYpLCAocmVnKSkpIHsgXAo+ IC0JCWlmIChkZXZfcHJpdi0+dW5jb3JlLmZvcmNld2FrZV9jb3VudCA9PSAwKSBcCj4gLQkJCWRl dl9wcml2LT51bmNvcmUuZnVuY3MuZm9yY2Vfd2FrZV9nZXQoZGV2X3ByaXYsIFwKPiAtCQkJCQkJ CUZPUkNFV0FLRV9BTEwpOyBcCj4gLQkJdmFsID0gX19yYXdfaTkxNV9yZWFkIyN4KGRldl9wcml2 LCByZWcpOyBcCj4gLQkJaWYgKGRldl9wcml2LT51bmNvcmUuZm9yY2V3YWtlX2NvdW50ID09IDAp IFwKPiAtCQkJZGV2X3ByaXYtPnVuY29yZS5mdW5jcy5mb3JjZV93YWtlX3B1dChkZXZfcHJpdiwg XAo+IC0JCQkJCQkJRk9SQ0VXQUtFX0FMTCk7IFwKPiAtCX0gZWxzZSB7IFwKPiAtCQl2YWwgPSBf X3Jhd19pOTE1X3JlYWQjI3goZGV2X3ByaXYsIHJlZyk7IFwKPiArCWlmIChkZXZfcHJpdi0+dW5j b3JlLmZvcmNld2FrZV9jb3VudCA9PSAwICYmIFwKPiArCSAgICBORUVEU19GT1JDRV9XQUtFKChk ZXZfcHJpdiksIChyZWcpKSkgeyBcCj4gKwkJZGV2X3ByaXYtPnVuY29yZS5mdW5jcy5mb3JjZV93 YWtlX2dldChkZXZfcHJpdiwgXAo+ICsJCQkJCQkgICAgICBGT1JDRVdBS0VfQUxMKTsgXAo+ICsJ CWRldl9wcml2LT51bmNvcmUuZm9yY2V3YWtlX2NvdW50Kys7IFwKPiArCQltb2RfdGltZXJfcGlu bmVkKCZkZXZfcHJpdi0+dW5jb3JlLmZvcmNlX3dha2VfdGltZXIsIFwKPiArCQkJCSBqaWZmaWVz ICsgMSk7IFwKPiAgCX0gXAo+ICsJdmFsID0gX19yYXdfaTkxNV9yZWFkIyN4KGRldl9wcml2LCBy ZWcpOyBcCj4gIAlSRUdfUkVBRF9GT09URVI7IFwKPiAgfQo+ICAKPiBAQCAtNjgxLDggKzY3Niw5 IEBAIHZvaWQgaW50ZWxfdW5jb3JlX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgewo+ ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsK PiAgCj4gLQlJTklUX0RFTEFZRURfV09SSygmZGV2X3ByaXYtPnVuY29yZS5mb3JjZV93YWtlX3dv cmssCj4gLQkJCSAgZ2VuNl9mb3JjZV93YWtlX3dvcmspOwo+ICsJc2V0dXBfdGltZXIoJmRldl9w cml2LT51bmNvcmUuZm9yY2Vfd2FrZV90aW1lciwKPiArCQkgICAgKHZvaWQgKCopKHVuc2lnbmVk IGxvbmcpKWdlbjZfZm9yY2Vfd2FrZV90aW1lciwKPiArCQkgICAgKHVuc2lnbmVkIGxvbmcpZGV2 X3ByaXYpOwo+ICAKPiAgCWlmIChJU19WQUxMRVlWSUVXKGRldikpIHsKPiAgCQlkZXZfcHJpdi0+ dW5jb3JlLmZ1bmNzLmZvcmNlX3dha2VfZ2V0ID0gX192bHZfZm9yY2Vfd2FrZV9nZXQ7Cj4gQEAg LTc5NCw3ICs3OTAsNyBAQCB2b2lkIGludGVsX3VuY29yZV9maW5pKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ ZGV2X3ByaXZhdGU7Cj4gIAo+IC0JZmx1c2hfZGVsYXllZF93b3JrKCZkZXZfcHJpdi0+dW5jb3Jl LmZvcmNlX3dha2Vfd29yayk7Cj4gKwlkZWxfdGltZXJfc3luYygmZGV2X3ByaXYtPnVuY29yZS5m b3JjZV93YWtlX3RpbWVyKTsKPiAgCj4gIAkvKiBQYXJhbm9pYTogbWFrZSBzdXJlIHdlIGhhdmUg ZGlzYWJsZWQgZXZlcnl0aGluZyBiZWZvcmUgd2UgZXhpdC4gKi8KPiAgCWludGVsX3VuY29yZV9z YW5pdGl6ZShkZXYpOwo+IC0tIAo+IDEuOS4wCj4gCgotLSAKQmVuIFdpZGF3c2t5LCBJbnRlbCBP cGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=