From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 5/5] drm/i915: Add SPLL sharing support for
 DDI
Date: Mon, 3 Mar 2014 11:56:08 +0200
Message-ID: <20140303095608.GV3852@intel.com>
References: <1393503796-31342-1-git-send-email-ville.syrjala@linux.intel.com>
	<1393503796-31342-6-git-send-email-ville.syrjala@linux.intel.com>
	<CA+gsUGRCcRrmaE3OuePatcXp9aFHgRVzQ1Qf_s=ak+3b2+WRDA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 18A14FB02B
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  3 Mar 2014 01:56:17 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CA+gsUGRCcRrmaE3OuePatcXp9aFHgRVzQ1Qf_s=ak+3b2+WRDA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Feb 28, 2014 at 06:40:22PM -0300, Paulo Zanoni wrote:
> Hi
> =

> 2014-02-27 9:23 GMT-03:00  <ville.syrjala@linux.intel.com>:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> >
> > Write some theoretical SPLL sharing support for DDI. Currently that will
> > never happens since we never use SPLL for anything but FDI. But having
> > the code there makes it easier if we ever want to do it, and it might
> > excercise the PLL sharing code a bit more.
> =

> One thing is that if we ever want to use SSC on eDP/DP/HDMI, we will
> want to use either SPLL or WRPLL instead of LCPLL. I always wanted to
> implement this, and recently I saw a bug that made me think about it
> again.
> =

> So instead of this patch, why don't you write support to use SSC when
> requested? We could do this through some i915.use_ssc command line
> option that would just try to force SSC on everything, or maybe a
> "debug connector property", or debugfs, or anything you might want.
> With this, you would be able to actually test your patches, and we'd
> have a useful feature.
> =

> If you disagree, please just say "no" and then I'll go back to review
> this patch :)

I think improving the PLL selection code should be a separate patch.
IIRC I even said as much in the cover letter.

-- =

Ville Syrj=E4l=E4
Intel OTC