From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 1/2] drm/i915: s/any_enabled/!fallback/ in
 fbdev_initial_config
Date: Tue, 4 Mar 2014 12:30:50 -0800
Message-ID: <20140304123050.781aab27@jbarnes-desktop>
References: <1393963722-5617-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from qproxy1-pub.mail.unifiedlayer.com
	(qproxy1-pub.mail.unifiedlayer.com [173.254.64.10])
	by gabe.freedesktop.org (Postfix) with SMTP id 85368FA6BB
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  4 Mar 2014 12:30:24 -0800 (PST)
In-Reply-To: <1393963722-5617-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue,  4 Mar 2014 21:08:41 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

> It started as a simple check whether anything is lit up, but now is't
> used to driver the general fallback logic to the default output
> configuration selector in the helper library. So rename it for more
> clarity.
> 
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/intel_fbdev.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
> index 4e4b461e0a70..df00e6b01f0d 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -289,7 +289,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
>  	struct drm_device *dev = fb_helper->dev;
>  	int i, j;
>  	bool *save_enabled;
> -	bool any_enabled = false;
> +	bool fallback = true;
>  
>  	/*
>  	 * If the user specified any force options, just bail here
> @@ -347,7 +347,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
>  		 */
>  		for (j = 0; j < fb_helper->connector_count; j++) {
>  			if (crtcs[j] == new_crtc) {
> -				any_enabled = false;
> +				fallback = true;
>  				goto out;
>  			}
>  		}
> @@ -390,11 +390,11 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
>  			      encoder->crtc->base.id,
>  			      modes[i]->name);
>  
> -		any_enabled = true;
> +		fallback = false;
>  	}
>  
>  out:
> -	if (!any_enabled) {
> +	if (fallback) {
>  		memcpy(enabled, save_enabled, dev->mode_config.num_connector);
>  		kfree(save_enabled);
>  		return false;

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center