From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 0/9] [v2] BDW 4G GGTT + PPGTT cleanups Date: Tue, 4 Mar 2014 15:50:12 +0100 Message-ID: <20140304145000.GG17001@phenom.ffwll.local> References: <1392244132-6806-1-git-send-email-benjamin.widawsky@intel.com> <1392876349-24684-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com [209.85.215.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 02692FB738 for ; Tue, 4 Mar 2014 06:50:16 -0800 (PST) Received: by mail-ea0-f182.google.com with SMTP id b10so408942eae.27 for ; Tue, 04 Mar 2014 06:50:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <1392876349-24684-1-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Wed, Feb 19, 2014 at 10:05:40PM -0800, Ben Widawsky wrote: > Thanks to Imre's very detailed review, and Ville's observation of a > missed free (earlier bug), I think the series is finally starting to > shape up. I am having some unrelated problems on my BDW platform at the > moment, so they are not well tested. > > Many patches are way past v2, but for th series it's the second > iteration. fyi threading here is funky - if you want to reply a complete resend to an old series please only do the cover letter as a direct reply, but make the individual patches replies to the cover letter. I'm prone to make a giant mess out of things otherwise ;-) But in general if you resend everything, a new thread is in order - in reply resends is just for individual patches to keep an ongoing review discussion tightly grouped together. -Daniel > > Ben Widawsky (9): > drm/i915/bdw: Free PPGTT struct > drm/i915/bdw: Reorganize PPGTT init > drm/i915/bdw: Split ppgtt initialization up > drm/i915: Make clear/insert vfuncs args absolute > drm/i915/bdw: Reorganize PT allocations > Revert "drm/i915/bdw: Limit GTT to 2GB" > drm/i915: Update i915_gem_gtt.c copyright > drm/i915: Split GEN6 PPGTT cleanup > drm/i915: Split GEN6 PPGTT initialization up > > drivers/gpu/drm/i915/i915_drv.h | 11 +- > drivers/gpu/drm/i915/i915_gem_gtt.c | 582 ++++++++++++++++++++++++------------ > 2 files changed, 405 insertions(+), 188 deletions(-) > > -- > 1.9.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch