From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 01/13] drm/i915: Move semaphore specific ring members to struct Date: Wed, 5 Mar 2014 14:29:44 +0200 Message-ID: <20140305122944.GP3852@intel.com> References: <1392877166-9195-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id E60C7FA5F8 for ; Wed, 5 Mar 2014 04:29:47 -0800 (PST) Content-Disposition: inline In-Reply-To: <1392877166-9195-1-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org Looks like I neglected to give any kind of final conclusion on this series. It looks like it should do the right thing, apart from the PAGE_MASK vs. /4 bug. The other things I commented on were just minor nits. And if we drop the poll and force restore patches, I'm happy with the result ;) -- = Ville Syrj=E4l=E4 Intel OTC