public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Ben Widawsky <ben@bwidawsk.net>,
	Mika Kuoppala <mika.kuoppala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org, miku@iki.fi
Subject: Re: [PATCH 2/3] drm/i915: Record pid/comm of hanging task
Date: Wed, 5 Mar 2014 14:34:48 +0100	[thread overview]
Message-ID: <20140305133448.GM17001@phenom.ffwll.local> (raw)
In-Reply-To: <20140305130815.GA308@nuc-i3427.alporthouse.com>

On Wed, Mar 05, 2014 at 01:08:15PM +0000, Chris Wilson wrote:
> On Wed, Feb 12, 2014 at 11:32:00AM -0800, Ben Widawsky wrote:
> > On Wed, Feb 12, 2014 at 07:18:19PM +0000, Chris Wilson wrote:
> > > On Wed, Feb 12, 2014 at 10:55:07AM -0800, Ben Widawsky wrote:
> > > > On Wed, Feb 12, 2014 at 08:15:58AM +0000, Chris Wilson wrote:
> > > > Are you opposed to doing anything at context creation? pid reference
> > > > works for me too, or hold on to it with the request - I don't care.
> > > 
> > > I'm just don't feel that the issue is severe enough for yet another pid
> > > reference floating around inside drm. I could well be wrong though, but
> > > I would like to be sure we have tried our best to use the available
> > > information we have already.
> > > -Chris
> > > 
> > > -- 
> > > Chris Wilson, Intel Open Source Technology Centre
> > 
> > Well, the ref wouldn't be held if you just copied it at context create,
> > and it avoids having to stick in *file to actually do the proper look up
> > (not that that in itself is so horrible).
> > 
> > For the sake of making progress, I disagree with Chris in tbut think it's
> > better than what is currently there, so:
> > Acked-by: Ben Widawsky <ben@bwidawsk.net>
> 
> Daniel?

I've thought I pick this all up when Mika resends the revised versions for
1&3. Or is everything ready already (it didn't quite look like that ...)?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-03-05 13:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 14:30 [PATCH 1/3] drm/i915: Rely on accurate request tracking for finding hung batches Mika Kuoppala
2014-02-10 14:30 ` [PATCH 2/3] drm/i915: Record pid/comm of hanging task Mika Kuoppala
2014-02-12  2:07   ` Ben Widawsky
2014-02-12  8:15     ` Chris Wilson
2014-02-12 18:55       ` Ben Widawsky
2014-02-12 19:18         ` Chris Wilson
2014-02-12 19:32           ` Ben Widawsky
2014-03-05 13:08             ` Chris Wilson
2014-03-05 13:34               ` Daniel Vetter [this message]
2014-03-05 13:50                 ` Chris Wilson
2014-02-10 14:30 ` [PATCH 3/3] drm/i915: Record error state capture reason Mika Kuoppala
2014-02-12  2:32   ` Ben Widawsky
2014-02-12  8:13     ` Chris Wilson
2014-02-12 19:05       ` Ben Widawsky
2014-02-12  1:57 ` [PATCH 1/3] drm/i915: Rely on accurate request tracking for finding hung batches Ben Widawsky
2014-02-12  8:25   ` Chris Wilson
2014-02-12 19:02     ` Ben Widawsky
2014-02-12 19:15       ` Chris Wilson
2014-02-12 17:47 ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305133448.GM17001@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=ben@bwidawsk.net \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@linux.intel.com \
    --cc=miku@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox