public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Reset vma->mm_list after unbinding
Date: Wed, 5 Mar 2014 15:15:25 +0100	[thread overview]
Message-ID: <20140305141525.GY17001@phenom.ffwll.local> (raw)
In-Reply-To: <20140305130529.GD21413@nuc-i3427.alporthouse.com>

On Wed, Mar 05, 2014 at 01:05:29PM +0000, Chris Wilson wrote:
> On Tue, Feb 25, 2014 at 03:38:18PM -0800, Ben Widawsky wrote:
> > On Tue, Feb 25, 2014 at 02:23:28PM +0000, Chris Wilson wrote:
> > > In place of true activity counting, we walk the list of vma associated
> > > with an object managing each on the vm's active/inactive list everytime
> > > we call move-to-inactive. This depends upon the vma->mm_list being
> > > cleared after unbinding, or else we run into difficulty when tracking
> > > the object in multiple vm's - we see a use-after free and corruption of
> > > the mm_list.
> > 
> > I feel bad because someone in PRC told me about this bug, and I could
> > have sword you had previously fixed it. So if you're reading this
> > whomever you were, my apoligies.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Ben Widawsky <ben@bwidawsk.net>
> > 
> > I think Cc: stable too
> > 
> > Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> 
> Daniel?
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-03-05 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-25 14:23 [PATCH] drm/i915: Reset vma->mm_list after unbinding Chris Wilson
2014-02-25 23:38 ` Ben Widawsky
2014-03-05 13:05   ` Chris Wilson
2014-03-05 14:15     ` Daniel Vetter [this message]
2014-02-27 14:11 ` Ville Syrjälä
2014-02-27 14:28   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140305141525.GY17001@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox