From: Daniel Vetter <daniel@ffwll.ch>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Paulo Zanoni" <przanoni@gmail.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/5] drm/i915: Change intel_fdi_link_freq() to 10kHz
Date: Wed, 5 Mar 2014 16:04:54 +0100 [thread overview]
Message-ID: <20140305150454.GD17001@phenom.ffwll.local> (raw)
In-Reply-To: <20140301073412.GH21275@nuc-i3427.alporthouse.com>
On Sat, Mar 01, 2014 at 07:34:12AM +0000, Chris Wilson wrote:
> On Fri, Feb 28, 2014 at 07:28:41PM -0300, Paulo Zanoni wrote:
> > 2014-02-27 9:23 GMT-03:00 <ville.syrjala@linux.intel.com>:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > We normally use 10Khz units when describing DP link frequency.
> > > Have intel_fdi_link_freq() return the same units. I always get confused
> > > when the units start to be totally different.
> > >
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > A nice simplification!
>
> An oversimplification. link_bw != link_freq.
Yeah, I think we need a s/link_freq/link_bw now ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-03-05 15:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 12:23 [PATCH 0/5] drm/i915: FDI port_clock fix for DDI and other FDI changes ville.syrjala
2014-02-27 12:23 ` [PATCH 1/5] drm/i915: Fix DDI port_clock for VGA output ville.syrjala
2014-02-28 22:09 ` Paulo Zanoni
2014-03-03 10:09 ` Ville Syrjälä
2014-02-27 12:23 ` [PATCH 2/5] drm/i915: Change intel_fdi_link_freq() to 10kHz ville.syrjala
2014-02-28 22:28 ` Paulo Zanoni
2014-03-01 7:34 ` Chris Wilson
2014-03-05 15:04 ` Daniel Vetter [this message]
2014-03-06 21:01 ` Daniel Vetter
2014-02-27 12:23 ` [PATCH 3/5] drm/i915: Use DIV_ROUND_UP() when calculating number of required FDI lanes ville.syrjala
2014-02-28 22:35 ` Paulo Zanoni
2014-02-27 12:23 ` [PATCH 4/5] drm/i915: Use port_clock for FDI frequency on DDI ville.syrjala
2014-02-27 12:23 ` [PATCH 5/5] drm/i915: Add SPLL sharing support for DDI ville.syrjala
2014-02-28 21:40 ` Paulo Zanoni
2014-03-03 9:56 ` Ville Syrjälä
2014-03-05 15:09 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305150454.GD17001@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox