From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 00/23] Merge PC8 with runtime PM, v2 Date: Wed, 5 Mar 2014 18:09:17 +0100 Message-ID: <20140305170917.GJ17001@phenom.ffwll.local> References: <1393540010-1582-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f52.google.com (mail-ee0-f52.google.com [74.125.83.52]) by gabe.freedesktop.org (Postfix) with ESMTP id 137C3FA80C for ; Wed, 5 Mar 2014 09:09:24 -0800 (PST) Received: by mail-ee0-f52.google.com with SMTP id e49so603824eek.39 for ; Wed, 05 Mar 2014 09:09:22 -0800 (PST) Content-Disposition: inline In-Reply-To: <1393540010-1582-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Thu, Feb 27, 2014 at 07:26:27PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Hi > > This is the second time I send this series to the mailing list. Please read the > first cover letter: > http://lists.freedesktop.org/archives/intel-gfx/2013-December/037721.html > > What's new? > > Two main differences: > - Added a patch from Chris, which resulted in a change on how we handle > dev_priv->pc8.gpu_busy later. > - Fixed a bug on the forcewake handling. > > There is some discussion if we want to merge this first, or the VLV power wells > patches first. Independently of the decision, I think we should try to at least > discuss these patches and review what can be reviewed. I really think this > series should make it easier to add runtime PM support to other platforms, and I > even added BDW and SNB support on top of these patches. Looks good. Only too imo minor things: - Drop the runtime pm get/put from the forcewake get/put functions and adjust callers accordingly to grab the runtime pm ref themselves outside of the register access. That should fully address Chris'&mine concern in that regard. I only expect a minor impact here, if that turns out wrong please complain and we need to take another look. - The aux display power domain patch. Needs acks from platform owners imo, I'd just keep it for now. Also I've merged quite a few patches already, hopefully the most recent versions. When rebasing pls collect all the r-b tags for speedy merging. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch