From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 00/13] Gen7 batch buffer command parser
Date: Wed, 5 Mar 2014 18:14:38 +0100
Message-ID: <20140305171438.GL17001@phenom.ffwll.local>
References: <1392747357-25703-1-git-send-email-bradley.d.volkin@intel.com>
	<20140305104635.GY17001@phenom.ffwll.local>
	<20140305165956.GA27629@bdvolkin-ubuntu-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f52.google.com (mail-ee0-f52.google.com [74.125.83.52])
	by gabe.freedesktop.org (Postfix) with ESMTP id 9F899FA81D
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  5 Mar 2014 09:14:43 -0800 (PST)
Received: by mail-ee0-f52.google.com with SMTP id e49so604653eek.11
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 05 Mar 2014 09:14:42 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20140305165956.GA27629@bdvolkin-ubuntu-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: "Volkin, Bradley D" <bradley.d.volkin@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Mar 05, 2014 at 08:59:56AM -0800, Volkin, Bradley D wrote:
> On Wed, Mar 05, 2014 at 02:46:35AM -0800, Daniel Vetter wrote:
> > On Tue, Feb 18, 2014 at 10:15:44AM -0800, bradley.d.volkin@intel.com wrote:
> > > From: Brad Volkin <bradley.d.volkin@intel.com>
> > > 3) Coherency. I've previously found a coherency issue on VLV when reading the
> > >    batch buffer from the CPU during execbuffer2. Userspace writes the batch via
> > >    pwrite fast path before calling execbuffer2. The parser reads stale data.
> > >    This works fine on IVB and HSW, so I believe it's an LLC vs. non-LLC issue.
> > >    It's possible that the shmem pread refactoring fixes this, I just have not
> > >    been able to retest due to lack of a VLV system.
> > 
> > Is it still true that we need to test this on vlv? The shmem_pread path
> > really should have fixed this ... Otherwise I think this looks ready to go
> > in, I'll pester Jani for the review.
> 
> Yes, I still don't have a system to test on.

Steal one? I guess we'll notice when our QA runs all this stuff on theirs
;-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch