From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: reverse dp link param selection, prefer fast over wide again Date: Wed, 5 Mar 2014 19:14:47 +0100 Message-ID: <20140305181447.GU17001@phenom.ffwll.local> References: <1393841890-15549-1-git-send-email-daniel.vetter@ffwll.ch> <87lhwrpcx0.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id CE2C3FA8AC for ; Wed, 5 Mar 2014 10:14:52 -0800 (PST) Received: by mail-ee0-f44.google.com with SMTP id e49so631871eek.31 for ; Wed, 05 Mar 2014 10:14:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <87lhwrpcx0.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jani Nikula Cc: Daniel Vetter , Intel Graphics Development , peter@colberg.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 03, 2014 at 04:36:11PM +0200, Jani Nikula wrote: > On Mon, 03 Mar 2014, Daniel Vetter wrote: > > ... it's this time of the year again. Originally we've frobbed this to > > fix up some regressions, but maybe our DP code improved sufficiently > > now that we can dare to do again what the spec recommends. > > > > This reverts > > > > commit 2514bc510d0c3aadcc5204056bb440fa36845147 > > Author: Jesse Barnes > > Date: Thu Jun 21 15:13:50 2012 -0700 > > > > drm/i915: prefer wide & slow to fast & narrow in DP configs > > > > I'm pretty sure I'll regret this patch, but otoh I expect we won't > > make progress here without poking the devil occasionally. > > Reviewed-by: Jani Nikula > > I agree we should bite the bullet and do this. This is what the DP specs > tell us to do. I'm pretty sure there will be regressions, but I'm also > starting to believe there's a greater number of machines that are > currently either broken beyond repair or papered over with some hacks > than the number that will regress. We should just dig into them and fix > them instead of burying our heads in the sand. Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch