From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Daisy Sun <daisy.sun@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>,
Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] [v2] drm/i915/bdw: Add FBC support
Date: Wed, 5 Mar 2014 13:37:19 -0800 [thread overview]
Message-ID: <20140305213719.GB2777@intel.com> (raw)
In-Reply-To: <20140305110018.GA17001@phenom.ffwll.local>
On Wed, Mar 05, 2014 at 12:00:18PM +0100, Daniel Vetter wrote:
> On Fri, Feb 21, 2014 at 04:06:47PM -0300, Paulo Zanoni wrote:
> > 2014-02-20 21:01 GMT-03:00 Ben Widawsky <benjamin.widawsky@intel.com>:
> > > This got lost when we shuffled around our internal branch and
> > > GEN7_FEATURES macro. There were no HW changes to support FBC, so we just
> > > need to set the flag.
> > >
> > > v2: Don't allow FBC for any pipe but A on platforms with DDI. (Paulo)
> > >
> > > Cc: Daisy Sun <daisy.sun@intel.com>
> > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> >
> > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Have you guys run the fbc igt testcase to make sure it actually works? In
> case it's broken I'll back it out again ...
>
> Queued for -next, thanks for the patch.
> -Daniel
Daisy, I was led to believe you actually tested this. Is that correct?
Daniel, BTW, we have an unimplemented FBC bugfix (basically disable) on
HSW that carries over to BDW. It was not implemented last time I checked
anyway. I tried to implement it, but I don't know the code well enough.
Feel free to sign me up for review if someone else does it.
Also, 4k displays have some issue with FBC. So we'll need to address
that.
--
Ben Widawsky, Intel Open Source Technology Center
prev parent reply other threads:[~2014-03-05 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 2:32 [PATCH] drm/i915/bdw: Add FBC support Ben Widawsky
2014-02-21 0:01 ` [PATCH] [v2] " Ben Widawsky
2014-02-21 19:06 ` Paulo Zanoni
2014-03-05 11:00 ` Daniel Vetter
2014-03-05 21:37 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305213719.GB2777@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=ben@bwidawsk.net \
--cc=daisy.sun@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox