From: Damien Lespiau <damien.lespiau@intel.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915/bdw: MU_FLUSH_DW a qword instead of dword
Date: Wed, 5 Mar 2014 23:13:26 +0000 [thread overview]
Message-ID: <20140305231326.GA6992@strange.amr.corp.intel.com> (raw)
In-Reply-To: <20140305223849.GA24362@bwidawsk.net>
On Wed, Mar 05, 2014 at 02:38:50PM -0800, Ben Widawsky wrote:
> It wasn't completely fortuitous, I did check. I was lucky you think my
> check was satisfactory though. I agree it makes future code somewhat
> risky so maybe some improvement is needed to safeguard. I also have/had
> a patch to lengthen MI_STORE_DATA_INDEX. The decoder however does not
> complain about that one, and the windows team did neither. So I didn't
> want to change it for the sake of change.
Note that the decoder warns here because the shorter length is not valid
if you believe what's in the spec. It could actually work ok if the CS
hardware respects the length field, don't go fetch the missing dword,
and, as we're not using it, doesn't care too much (which seems to be the
case as we correctly jump to the next instruction). But not quite sure
how well defined this is.
--
Damien
prev parent reply other threads:[~2014-03-05 23:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 17:38 [PATCH] drm/i915/bdw: MU_FLUSH_DW a qword instead of dword Ben Widawsky
2014-03-05 9:24 ` Chris Wilson
2014-03-05 18:33 ` Daniel Vetter
2014-03-05 19:05 ` Ben Widawsky
2014-03-05 22:30 ` Chris Wilson
2014-03-05 22:38 ` Ben Widawsky
2014-03-05 23:13 ` Damien Lespiau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305231326.GA6992@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox