From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: Request for feedback : [RFC] Added a new 'window size' property for connector Date: Fri, 7 Mar 2014 15:01:22 +0200 Message-ID: <20140307130122.GJ3852@intel.com> References: <8BF5CF93467D8C498F250C96583BC09CC7C1D8@BGSMSX103.gar.corp.intel.com> <20140307092802.GG3852@intel.com> <8BF5CF93467D8C498F250C96583BC09CC7C24A@BGSMSX103.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id AA7A4FAC6F for ; Fri, 7 Mar 2014 05:02:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <8BF5CF93467D8C498F250C96583BC09CC7C24A@BGSMSX103.gar.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: "Goel, Akash" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Fri, Mar 07, 2014 at 12:45:26PM +0000, Goel, Akash wrote: > Thanks for your feedback. > = > > No, fb_id is passed through setcrtc (or soon through setplane, I hope). > Actually mentioned 'fb_id' also, because if PIPESRC programming is also b= eing updated (as Panel fitter input), then the 'fb' already attached to 'cr= tc' may not be aligned with it. So there could be a momentary corruption ca= used when internal modeset is done by Driver (to change the Panel fitter se= tting), which will last till the next page flip (or setplane). > = > = > > No, we need both the border and the PIPESRC information. hdisplay/vdisp= lays isn't enough since the user facing mode structure doesn't have vblank_= start/end fields. Hence we can't specify borders. > > If we don't want to extend the display mode, we should add border prope= rties of some sort. I know some drivers have added something like that to t= he connectors, but again since the mode is applied to the crtc, ideally the= se properties > > should also be on the crtc. > = > Sorry but it's not quite clear. This is what is my understanding so far, = please kindly correct wherever wrong. > = > 1. We need border info for the output of Panel fitter, which will deter= mine the display window. Using the border info we will manipulate the hblan= k/vblank start/end fields. > 2. Currently the values of 'hdisplay/vdisplay' fields sent in 'drm_mode= _modeinfo' structure gets programmed in PIPESRC. So if we are adding border= info to the same structure, then we can use the 'hdisplay/vdisplay' fields= only for = > PIPESRC. But if we are defining a new property, to convey the borde= r info, then we need the PIPESRC information also along with it. > = > Please confirm that should we add a new a 'blob' type property for 'crtc'= ? = In my ideal solution the panel fitter output will be hdisplay/vdisplay +/- the border (depending on which way we define it), and the panel fitter input size will be defined as a new crtc property. -- = Ville Syrj=E4l=E4 Intel OTC