From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 5/8] drm/i915: preserve SSC if previously set Date: Sat, 8 Mar 2014 11:34:05 +0100 Message-ID: <20140308103405.GM25837@phenom.ffwll.local> References: <1394211475-2646-1-git-send-email-jbarnes@virtuousgeek.org> <1394211475-2646-5-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f174.google.com (mail-ea0-f174.google.com [209.85.215.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 52654FAEF7 for ; Sat, 8 Mar 2014 02:34:11 -0800 (PST) Received: by mail-ea0-f174.google.com with SMTP id f15so2773478eak.19 for ; Sat, 08 Mar 2014 02:34:10 -0800 (PST) Content-Disposition: inline In-Reply-To: <1394211475-2646-5-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Mar 07, 2014 at 08:57:52AM -0800, Jesse Barnes wrote: > Some machines may have a broken VBT or no VBT at all, but we still want > to use SSC there. So check for it and keep it enabled if we see it > already on. Based on an earlier fix from Kristian. > = > Reported-by: Kristian H=F8gsberg > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_display.c | 4 ++++ > 1 file changed, 4 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 479de3b..d450ab6 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -5806,6 +5806,10 @@ static void ironlake_init_pch_refclk(struct drm_de= vice *dev) > */ > val =3D I915_READ(PCH_DREF_CONTROL); > = > + /* Preserve SSC if the BIOS set it */ > + if (val & DREF_SSC1_ENABLE) > + i915.panel_use_ssc =3D 1; This definitely needs some debug output, and we need to make sure that the module option still overrides this. -Daniel > + > /* As we must carefully and slowly disable/enable each source in turn, > * compute the final state we want first and check if we need to > * make any changes at all. > -- = > 1.8.4.2 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch