From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/4] drm/i915: Make encoder cloning more flexible Date: Mon, 10 Mar 2014 21:17:38 +0200 Message-ID: <20140310191738.GU3852@intel.com> References: <1393856131-16961-1-git-send-email-ville.syrjala@linux.intel.com> <1393856131-16961-2-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id AB872FA5C7 for ; Mon, 10 Mar 2014 12:18:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Rodrigo Vivi Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 10, 2014 at 03:27:09PM -0300, Rodrigo Vivi wrote: > On Mon, Mar 3, 2014 at 11:15 AM, wrote: > > diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/int= el_tv.c > > index b64fc1c..5be4ab2 100644 > > --- a/drivers/gpu/drm/i915/intel_tv.c > > +++ b/drivers/gpu/drm/i915/intel_tv.c > > @@ -1639,9 +1639,8 @@ intel_tv_init(struct drm_device *dev) > > intel_connector_attach_encoder(intel_connector, intel_encoder); > > intel_encoder->type =3D INTEL_OUTPUT_TVOUT; > > intel_encoder->crtc_mask =3D (1 << 0) | (1 << 1); > > - intel_encoder->cloneable =3D false; > > + intel_encoder->cloneable =3D 0; > > intel_encoder->base.possible_crtcs =3D ((1 << 0) | (1 << 1)); > > - intel_encoder->base.possible_clones =3D (1 << INTEL_OUTPUT_TVOU= T); > = > why did you remove this? > or shouldn't it be a separated patch at least? It has no business being here. We compute possible_clones dynamically so this will get overwritten. I forgot to mention it in the commits msg. It could be a separate patch, but since it does nothing just killing it as part of this patch seems fine. > = > The rest of the approach looks ok for me, so with this explained or > fixed feel free to use > Reviewed-by: Rodrigo Vivi > = > > intel_tv->type =3D DRM_MODE_CONNECTOR_Unknown; > > > > /* BIOS margin values */ > > -- > > 1.8.3.2 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > = > = > -- = > Rodrigo Vivi > Blog: http://blog.vivi.eng.br -- = Ville Syrj=E4l=E4 Intel OTC