From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fix typo in display IRQ mask when
 disabling IRQs
Date: Mon, 10 Mar 2014 21:50:05 +0100
Message-ID: <20140310205005.GC30571@phenom.ffwll.local>
References: <1394473488-11179-1-git-send-email-imre.deak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ea0-f176.google.com (mail-ea0-f176.google.com
	[209.85.215.176])
	by gabe.freedesktop.org (Postfix) with ESMTP id 88573FA6E6
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 10 Mar 2014 13:50:09 -0700 (PDT)
Received: by mail-ea0-f176.google.com with SMTP id o10so3873320eaj.21
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 10 Mar 2014 13:50:08 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1394473488-11179-1-git-send-email-imre.deak@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Fengguang Wu <fengguang.wu@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Mar 10, 2014 at 07:44:48PM +0200, Imre Deak wrote:
> Introduced in
> commit e0e33f8ff6f0b6d286afc314802be4993341bd47
> Author: Imre Deak <imre.deak@intel.com>
> Date:   Tue Mar 4 19:23:07 2014 +0200
> 
> The impact was luckily minimal, due to the extra check we do against a
> software pipestat IRQ mask.
> 
> Caught by Fengguang's 0-day tester.
> 
> Cc: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index be2713f..c8e262f 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3074,7 +3074,7 @@ static void valleyview_display_irqs_uninstall(struct drm_i915_private *dev_priv)
>  
>  	iir_mask = I915_DISPLAY_PORT_INTERRUPT |
>  		   I915_DISPLAY_PIPE_A_EVENT_INTERRUPT |
> -		   I915_DISPLAY_PIPE_A_EVENT_INTERRUPT;
> +		   I915_DISPLAY_PIPE_B_EVENT_INTERRUPT;

Oops. Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch