From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Correct PPGTT total size Date: Tue, 11 Mar 2014 21:06:37 +0100 Message-ID: <20140311200637.GG30571@phenom.ffwll.local> References: <1394308697-3683-1-git-send-email-benjamin.widawsky@intel.com> <1394308697-3683-2-git-send-email-benjamin.widawsky@intel.com> <20140311122112.GD7348@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 09EFFFA233 for ; Tue, 11 Mar 2014 13:06:41 -0700 (PDT) Received: by mail-ee0-f43.google.com with SMTP id e53so3915416eek.2 for ; Tue, 11 Mar 2014 13:06:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140311122112.GD7348@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Ben Widawsky , Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 11, 2014 at 12:21:12PM +0000, Chris Wilson wrote: > On Sat, Mar 08, 2014 at 11:58:17AM -0800, Ben Widawsky wrote: > > Our code allows have a PPGTT that is smaller than the maximum size for > > GEN6-GEN7. Though I don't think this actually ever occurs, the code may > > as well work properly and more importantly look correct by using the > > variable size instead of the HW max. > > Might mention that the num_pd_entries is set during allocation of the > page directories, and so here we just compute the size for the drm_mm > range manager (and the variables only exist for consistency with legacy > GGTT interfaces). > > > Signed-off-by: Ben Widawsky > Reviewed-by: Chris Wilson Both merged, thanks for patches&review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch