From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 4/4] drm/i915: Wait for vblank in
 hsw_enable_ips()
Date: Wed, 12 Mar 2014 11:14:15 +0200
Message-ID: <20140312091415.GE20292@intel.com>
References: <1394559456-7348-1-git-send-email-ville.syrjala@linux.intel.com>
	<1394559456-7348-5-git-send-email-ville.syrjala@linux.intel.com>
	<20140312083637.GH23307@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5F9A4FACCD
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 12 Mar 2014 02:14:42 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140312083637.GH23307@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Mar 12, 2014 at 08:36:37AM +0000, Chris Wilson wrote:
> On Tue, Mar 11, 2014 at 07:37:36PM +0200, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > Now that the vblank wait is gone from intel_enable_primary_plane(),
> > hsw_enable_ips() needs to do the vblank wait itself.
> =

> This should be done before removing the wait from
> intel_enable_primary_plane() for correctness?

Yeah reordering the patches would be better. I just realized this
issue after I had already done the other patches and being a bit
lazy I just slapped the fix on top.

-- =

Ville Syrj=E4l=E4
Intel OTC