From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/4] drm/i915: Drop the excessive vblank
 waits from modeset codepaths
Date: Wed, 12 Mar 2014 11:16:59 +0200
Message-ID: <20140312091659.GF20292@intel.com>
References: <1394559456-7348-1-git-send-email-ville.syrjala@linux.intel.com>
	<1394559456-7348-4-git-send-email-ville.syrjala@linux.intel.com>
	<20140312083539.GG23307@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7963FFAD81
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 12 Mar 2014 02:17:52 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140312083539.GG23307@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Mar 12, 2014 at 08:35:39AM +0000, Chris Wilson wrote:
> On Tue, Mar 11, 2014 at 07:37:35PM +0200, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > Now that we've plugged the mmio vs. ring flip race, we shouldn't need
> > these vblank waits in the modeset codepaths anymore. So get rid of
> > them.
> =

> Hmm, could we not add an assert(DSPSURFLIVE =3D=3D
> intel_crtc->dspsurf)?

Where would you want the assert?

> And maybe start tracking the frame counters?

Tracking them for what purpose?

-- =

Ville Syrj=E4l=E4
Intel OTC