From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 0/3] disable rings before sync flush Date: Wed, 12 Mar 2014 16:07:38 +0100 Message-ID: <20140312150738.GK30571@phenom.ffwll.local> References: <20140312081205.GC23307@nuc-i3427.alporthouse.com> <1394622582-21762-1-git-send-email-naresh.kumar.kachhi@intel.com> <20140312112803.GL23307@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 023D6FA977 for ; Wed, 12 Mar 2014 08:07:42 -0700 (PDT) Received: by mail-ee0-f43.google.com with SMTP id e53so4380150eek.2 for ; Wed, 12 Mar 2014 08:07:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140312112803.GL23307@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , naresh.kumar.kachhi@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 12, 2014 at 11:28:03AM +0000, Chris Wilson wrote: > On Wed, Mar 12, 2014 at 04:39:39PM +0530, naresh.kumar.kachhi@intel.com wrote: > > From: Naresh Kumar Kachhi > > > > initial version: stop rings before sync flush > > > > v1: address the comments from Chris Wilson on > > http://www.spinics.net/lists/intel-gfx/msg41025.html. > > Rather than adding stop and start ring, we are moving > > ring disable before hw_status_page_setup (sync flush). > > > > v2: Based on Chris's suggestion. Added one more patch to wait > > until the rings become idle after disabling. In case of timeout > > we log a message. > > > > Naresh Kumar Kachhi (3): > > drm/i915: disable rings before HW status page setup > > drm/i915: wait for rings to become idle once disabled > > drm/i915: warn if ring is active before sync flush > > > > drivers/gpu/drm/i915/i915_reg.h | 2 ++ > > drivers/gpu/drm/i915/intel_ringbuffer.c | 18 +++++++++++++----- > > drivers/gpu/drm/i915/intel_ringbuffer.h | 2 ++ > > 3 files changed, 17 insertions(+), 5 deletions(-) > > With the minor changes in patch 2, > Reviewed-by: Chris Wilson > and the recommendation for stable@ All 3 merged with the request polish applied to the 2nd patch. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch